Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get rid of global style workarounds #23

Closed
arlyon opened this issue Dec 23, 2022 · 3 comments
Closed

Get rid of global style workarounds #23

arlyon opened this issue Dec 23, 2022 · 3 comments

Comments

@arlyon
Copy link
Owner

arlyon commented Dec 23, 2022

Right now for both global styles and emotion styles we rely on some ugly workarounds to handle some 'odd' behaviour from SWC which is described in this comment: swc-project/swc#6233 (comment). Our only recourse is to sit and wait until they are resolved upstream.
@aplr
Copy link

aplr commented Jan 19, 2023

Hey, I guess the fix landed upstream now, have you already been able to test if it's working without the workarounds?

@arlyon
Copy link
Owner Author

arlyon commented Feb 20, 2023 •
edited
Loading

I had a look today, and it seems that we are still affected by a similar but unrelated issue to the one linked. This comment swc-project/swc#5068 (comment) seems to be particularly salient, as it seems that the main issue is the variable renamer going ham. As of today it seems that we still have no solution, sadly.

@arlyon arlyon pinned this issue May 15, 2023
@arlyon
Copy link
Owner Author

arlyon commented Jun 9, 2023

Happy to say that this is resolved.

@arlyon arlyon closed this as completed Jun 9, 2023
@arlyon arlyon unpinned this issue Jun 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@aplr @arlyon