Merge pull request ipfs#44 from ipfs/fix/errors

Stebalien · web-flow · commit 2442feaa25f7 · 2019-07-25T18:55:32.000-07:00
fix: return ErrLinkNotFound when the _link_ isn't found
diff --git a/node.go b/node.go
@@ -138,7 +138,7 @@ func (n *ProtoNode) RemoveNodeLink(name string) error {
 	}
 
 	if !found {
-		return ipld.ErrNotFound
+		return ErrLinkNotFound
 	}
 
 	n.links = ref
diff --git a/node_test.go b/node_test.go
@@ -59,7 +59,7 @@ func TestRemoveLink(t *testing.T) {
 
 	// should fail
 	err = nd.RemoveNodeLink("a")
-	if err != ipld.ErrNotFound {
+	if err != ErrLinkNotFound {
 		t.Fatal("should have failed to remove link")
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -138,7 +138,7 @@ func (n *ProtoNode) RemoveNodeLink(name string) error {`
`138`	`138`	`}`
`139`	`139`
`140`	`140`	`if !found {`
`141`		`- return ipld.ErrNotFound`
	`141`	`+ return ErrLinkNotFound`
`142`	`142`	`}`
`143`	`143`
`144`	`144`	`n.links = ref`
Original file line number	Diff line number	Diff line change
`@@ -59,7 +59,7 @@ func TestRemoveLink(t *testing.T) {`
`59`	`59`
`60`	`60`	`// should fail`
`61`	`61`	`err = nd.RemoveNodeLink("a")`
`62`		`- if err != ipld.ErrNotFound {`
	`62`	`+ if err != ErrLinkNotFound {`
`63`	`63`	`t.Fatal("should have failed to remove link")`
`64`	`64`	`}`
`65`	`65`