Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reenable slither on wallet contracts and updates to make nightly build pass #175

Merged
merged 5 commits into from
Nov 18, 2020

Conversation

elenadimitrova
Copy link
Contributor

@elenadimitrova elenadimitrova commented Nov 17, 2020

Reenable slither on the ./contracts/wallet contracts which was disabled due to crytic/slither#405

Ignored two warnings raised by slither on the already deployed ArgentWalletDetector contract:

INFO:Detectors:
0: getImplementations() should be declared external:
	- ArgentWalletDetector.getImplementations() (infrastructure/ArgentWalletDetector.sol#112-114)
1: getCodes() should be declared external:
	- ArgentWalletDetector.getCodes() (infrastructure/ArgentWalletDetector.sol#119-121)
Reference: https://github.com/crytic/slither/wiki/Detector-Documentation#public-function-that-could-be-declared-external

And one on the VersionManager

0: init(address) should be declared external:
	- VersionManager.init(address) (modules/VersionManager.sol#221)
	- UpgraderToVersionManager.init(address) (modules/UpgraderToVersionManager.sol#59-76)
Reference: https://github.com/crytic/slither/wiki/Detector-Documentation#public-function-that-could-be-declared-external

Green build: https://app.circleci.com/pipelines/github/argentlabs/argent-contracts/1446/workflows/55e8a7dc-1ec9-49f0-a885-1ab6fc3dcb8a/jobs/1765

@elenadimitrova elenadimitrova self-assigned this Nov 17, 2020
@elenadimitrova elenadimitrova force-pushed the maintenance/slither-updates branch from a4cbfa1 to 4324726 Compare November 17, 2020 16:40
@elenadimitrova elenadimitrova force-pushed the maintenance/slither-updates branch from 37a4952 to a67c735 Compare November 17, 2020 20:01
@elenadimitrova elenadimitrova marked this pull request as ready for review November 18, 2020 08:22
@elenadimitrova elenadimitrova force-pushed the maintenance/slither-updates branch from 6e11b6f to 5f25e95 Compare November 18, 2020 08:23
@elenadimitrova elenadimitrova force-pushed the maintenance/slither-updates branch from 5f25e95 to 8f7392a Compare November 18, 2020 08:25
@elenadimitrova elenadimitrova merged commit 5be4a7d into develop Nov 18, 2020
@elenadimitrova elenadimitrova deleted the maintenance/slither-updates branch November 18, 2020 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants