Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WiFiClient connect timeout #252

Open
wants to merge 1 commit into
base: 2.x.x
Choose a base branch
from
Open

WiFiClient connect timeout #252

wants to merge 1 commit into from
+80 −41

Conversation

JAndrassy
Copy link
Contributor

@JAndrassy JAndrassy commented Sep 17, 2023 •
edited
Loading

Following the support in the firmware in arduino/nina-fw#89, here is the implementation of WiFiClient.connect timeout.

Additionally the strange 10 seconds waiting time is removed.

overview of Client API in Arduino networking libraries:
https://github.com/JAndrassy/Arduino-Networking-API/blob/main/ArduinoNetAPILibs.md#client-getters-and-setters

@JAndrassy JAndrassy mentioned this pull request Sep 17, 2023
Closed
@github-actions

This comment was marked as outdated.

Sign in to view
@per1234 per1234 added type: enhancement Proposed improvement topic: code Related to content of the project itself labels Sep 18, 2023
@JAndrassy JAndrassy force-pushed the client_connect_timeout branch from 0114f39 to 4aa71f6 Compare October 8, 2023 09:10
@github-actions
Copy link

github-actions bot commented Oct 8, 2023

Memory usage change @ 4aa71f6

Board flash % RAM for global variables %
arduino:mbed_nano:nanorp2040connect 💚 -280 - 0 -0.0 - 0.0 0 - 0 0.0 - 0.0
arduino:megaavr:uno2018:mode=on 💚 -390 - 0 -0.8 - 0.0 0 - 0 0.0 - 0.0
arduino:samd:mkrvidor4000 💚 -276 - 0 -0.11 - 0.0 0 - 0 0.0 - 0.0
arduino:samd:mkrwifi1010 💚 -276 - 0 -0.11 - 0.0 0 - 0 0.0 - 0.0
arduino:samd:nano_33_iot 💚 -276 - 0 -0.11 - 0.0 0 - 0 0.0 - 0.0
Click for full report table
Board examples/AP_SimpleWebServer
flash		 % examples/AP_SimpleWebServer
RAM for global variables		 % examples/ConnectNoEncryption
flash		 % examples/ConnectNoEncryption
RAM for global variables		 % examples/ConnectWithWEP
flash		 % examples/ConnectWithWEP
RAM for global variables		 % examples/ConnectWithWPA
flash		 % examples/ConnectWithWPA
RAM for global variables		 % examples/ConnectWithWPA2Enterprise
flash		 % examples/ConnectWithWPA2Enterprise
RAM for global variables		 % examples/ScanNetworks
flash		 % examples/ScanNetworks
RAM for global variables		 % examples/ScanNetworksAdvanced
flash		 % examples/ScanNetworksAdvanced
RAM for global variables		 % examples/SimpleWebServerWiFi
flash		 % examples/SimpleWebServerWiFi
RAM for global variables		 % examples/Tools/CheckFirmwareVersion
flash		 % examples/Tools/CheckFirmwareVersion
RAM for global variables		 % examples/Tools/FirmwareUpdater
flash		 % examples/Tools/FirmwareUpdater
RAM for global variables		 % examples/Tools/SerialNINAPassthrough
flash		 % examples/Tools/SerialNINAPassthrough
RAM for global variables		 % examples/WiFiChatServer
flash		 % examples/WiFiChatServer
RAM for global variables		 % examples/WiFiPing
flash		 % examples/WiFiPing
RAM for global variables		 % examples/WiFiSSLClient
flash		 % examples/WiFiSSLClient
RAM for global variables		 % examples/WiFiStorage
flash		 % examples/WiFiStorage
RAM for global variables		 % examples/WiFiUdpNtpClient
flash		 % examples/WiFiUdpNtpClient
RAM for global variables		 % examples/WiFiUdpSendReceiveString
flash		 % examples/WiFiUdpSendReceiveString
RAM for global variables		 % examples/WiFiWebClient
flash		 % examples/WiFiWebClient
RAM for global variables		 % examples/WiFiWebClientRepeating
flash		 % examples/WiFiWebClientRepeating
RAM for global variables		 % examples/WiFiWebServer
flash		 % examples/WiFiWebServer
RAM for global variables		 %
arduino:mbed_nano:nanorp2040connect -276 -0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 -276 -0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 -276 -0.0 0 0.0 0 0.0 0 0.0 -280 -0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 -280 -0.0 0 0.0 -280 -0.0 0 0.0 -276 -0.0 0 0.0
arduino:megaavr:uno2018:mode=on -374 -0.77 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 -374 -0.77 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 -374 -0.77 0 0.0 0 0.0 0 0.0 -390 -0.8 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 -390 -0.8 0 0.0 -390 -0.8 0 0.0 -374 -0.77 0 0.0
arduino:samd:mkrvidor4000 -272 -0.1 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 -272 -0.1 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 -272 -0.1 0 0.0 0 0.0 0 0.0 -276 -0.11 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 -276 -0.11 0 0.0 -276 -0.11 0 0.0 -272 -0.1 0 0.0
arduino:samd:mkrwifi1010 -272 -0.1 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 -272 -0.1 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 -272 -0.1 0 0.0 0 0.0 0 0.0 -276 -0.11 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 -276 -0.11 0 0.0 -276 -0.11 0 0.0 -272 -0.1 0 0.0
arduino:samd:nano_33_iot -272 -0.1 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 -272 -0.1 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 -272 -0.1 0 0.0 0 0.0 0 0.0 -276 -0.11 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 -276 -0.11 0 0.0 -276 -0.11 0 0.0 -272 -0.1 0 0.0
Click for full report CSV 
Board,examples/AP_SimpleWebServer<br>flash,%,examples/AP_SimpleWebServer<br>RAM for global variables,%,examples/ConnectNoEncryption<br>flash,%,examples/ConnectNoEncryption<br>RAM for global variables,%,examples/ConnectWithWEP<br>flash,%,examples/ConnectWithWEP<br>RAM for global variables,%,examples/ConnectWithWPA<br>flash,%,examples/ConnectWithWPA<br>RAM for global variables,%,examples/ConnectWithWPA2Enterprise<br>flash,%,examples/ConnectWithWPA2Enterprise<br>RAM for global variables,%,examples/ScanNetworks<br>flash,%,examples/ScanNetworks<br>RAM for global variables,%,examples/ScanNetworksAdvanced<br>flash,%,examples/ScanNetworksAdvanced<br>RAM for global variables,%,examples/SimpleWebServerWiFi<br>flash,%,examples/SimpleWebServerWiFi<br>RAM for global variables,%,examples/Tools/CheckFirmwareVersion<br>flash,%,examples/Tools/CheckFirmwareVersion<br>RAM for global variables,%,examples/Tools/FirmwareUpdater<br>flash,%,examples/Tools/FirmwareUpdater<br>RAM for global variables,%,examples/Tools/SerialNINAPassthrough<br>flash,%,examples/Tools/SerialNINAPassthrough<br>RAM for global variables,%,examples/WiFiChatServer<br>flash,%,examples/WiFiChatServer<br>RAM for global variables,%,examples/WiFiPing<br>flash,%,examples/WiFiPing<br>RAM for global variables,%,examples/WiFiSSLClient<br>flash,%,examples/WiFiSSLClient<br>RAM for global variables,%,examples/WiFiStorage<br>flash,%,examples/WiFiStorage<br>RAM for global variables,%,examples/WiFiUdpNtpClient<br>flash,%,examples/WiFiUdpNtpClient<br>RAM for global variables,%,examples/WiFiUdpSendReceiveString<br>flash,%,examples/WiFiUdpSendReceiveString<br>RAM for global variables,%,examples/WiFiWebClient<br>flash,%,examples/WiFiWebClient<br>RAM for global variables,%,examples/WiFiWebClientRepeating<br>flash,%,examples/WiFiWebClientRepeating<br>RAM for global variables,%,examples/WiFiWebServer<br>flash,%,examples/WiFiWebServer<br>RAM for global variables,%
arduino:mbed_nano:nanorp2040connect,-276,-0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,-276,-0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,-276,-0.0,0,0.0,0,0.0,0,0.0,-280,-0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,-280,-0.0,0,0.0,-280,-0.0,0,0.0,-276,-0.0,0,0.0
arduino:megaavr:uno2018:mode=on,-374,-0.77,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,-374,-0.77,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,-374,-0.77,0,0.0,0,0.0,0,0.0,-390,-0.8,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,-390,-0.8,0,0.0,-390,-0.8,0,0.0,-374,-0.77,0,0.0
arduino:samd:mkrvidor4000,-272,-0.1,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,-272,-0.1,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,-272,-0.1,0,0.0,0,0.0,0,0.0,-276,-0.11,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,-276,-0.11,0,0.0,-276,-0.11,0,0.0,-272,-0.1,0,0.0
arduino:samd:mkrwifi1010,-272,-0.1,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,-272,-0.1,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,-272,-0.1,0,0.0,0,0.0,0,0.0,-276,-0.11,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,-276,-0.11,0,0.0,-276,-0.11,0,0.0,-272,-0.1,0,0.0
arduino:samd:nano_33_iot,-272,-0.1,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,-272,-0.1,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,-272,-0.1,0,0.0,0,0.0,0,0.0,-276,-0.11,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,-276,-0.11,0,0.0,-276,-0.11,0,0.0,-272,-0.1,0,0.0

@JAndrassy JAndrassy mentioned this pull request Jan 29, 2024
Open
@per1234 per1234 linked an issue Jan 31, 2024 that may be closed by this pull request
Non blocking WiFi.begin() & Client.connect() #273
Open
@pennam pennam added the 2.x.x label Mar 19, 2025
@pennam pennam mentioned this pull request Mar 19, 2025
Closed
@github-actions github-actions bot removed the 2.x.x label Mar 20, 2025
@pennam pennam added the 2.x.x label Mar 25, 2025
@github-actions github-actions bot removed the 2.x.x label Mar 26, 2025
@pennam pennam changed the base branch from master to 2.x.x March 28, 2025 08:32
pennam
pennam requested changes Mar 28, 2025
View reviewed changes
Copy link
Contributor

@pennam pennam left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @JAndrassy Thanks for your contribution. I may have found a small bug, please take a look at my suggestion.

I think we should add the timeout parameter also to :

void ServerDrv::startClient(uint32_t ipAddress, uint16_t port, uint8_t sock, uint8_t protMode)

src/utility/server_drv.cpp
SpiDrv::sendParam((uint8_t*)host, host_len);
SpiDrv::sendParam((uint8_t*)&ipAddress, sizeof(ipAddress));
SpiDrv::sendParam(port);
SpiDrv::sendParam(&sock, 1);
SpiDrv::sendParam(&protMode, 1, LAST_PARAM);
SpiDrv::sendParam(&protMode, 1);
SpiDrv::sendParam(timeout, LAST_PARAM);

// pad to multiple of 4
int commandSize = 17 + host_len;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
int commandSize = 17 + host_len;
int commandSize = 19 + host_len;

Copy link
Contributor Author

@JAndrassy JAndrassy Mar 28, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand that padding and why it has 'readChar'.
the SPI read padding is unnecessary with nina-fw. the library inherited it from the old WiFi library code.
the 17 is not right even without the timeout parameter. it should be maybe 20 and with timeout added 23 (1 byte param size + 2 bytes param value).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pennam pennam pennam requested changes

Assignees
No one assigned
Labels
topic: code Related to content of the project itself type: enhancement Proposed improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Non blocking WiFi.begin() & Client.connect()
3 participants
@JAndrassy @pennam @per1234