Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup configuration causes build scripts to fail, requires JSON plugin #400

Closed
corydickson opened this issue Jul 3, 2019 · 3 comments
Closed

Comments

@corydickson
Copy link
Contributor

Here is the job that failed when trying to add the Markdown component: https://travis-ci.org/aragon/aragon-ui/jobs/553950501

It's complaining about not knowing how to handle JSON files. I run into the same issue on my local machine.

@bpierre
Copy link
Contributor

bpierre commented Jul 23, 2019

@Gh1dra Do you still have the issue with the newstyle branch? It shouldn’t be importing JSON files from node_modules 🤔

@corydickson
Copy link
Contributor Author

@bpierre Works like a charm on the newstyle branch, should I wait for that to get merged to master before rebasing? Closing #401

@sohkai
Copy link
Contributor

sohkai commented Oct 19, 2019

We've since set newstyle as the default, and it will be merged onto master eventually.

@sohkai sohkai closed this as completed Oct 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants