-
Notifications
You must be signed in to change notification settings - Fork 10.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow separators to be omitted from lists. #22714
Conversation
@swift-ci please test source compatibility |
4 similar comments
@swift-ci please test source compatibility |
@swift-ci please test source compatibility |
@swift-ci please test source compatibility |
@swift-ci please test source compatibility |
@nate-chandler I wrote some tests for the IDE side; it looks like everything I've thought about is already working, which is great. I pushed an |
@benlangmuir Fantastic! Will do. |
@benlangmuir Okay, the commits are cherry-picked to |
@swift-ci please test |
Build failed |
Build failed |
@swift-ci please test |
Build failed |
Build failed |
@swift-ci please test |
Build failed |
Build failed |
@swift-ci please test |
Build failed |
Build failed |
Allowing them here enables function calls with argument labels whose names are contextual keywords that introduce stmts (for) and decls (protocol).
@swift-ci please test source compatibility |
Build failed |
Build failed |
@swift-ci Please clean test Linux platform |
Build failed |
Fixed whitespace.
@swift-ci please clean test |
Build failed |
Build failed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@swift-ci please clean test |
Build failed |
Build failed |
@swift-ci please test source compatibility |
@swift-ci build toolchain |
@swift-ci clean build toolchain |
@swift-ci clean build |
I tried the toolchain and it doesn't seem to allow me eliding commas in parameter lists |
Hi @hartbit, Thanks for the report! What you're seeing is intentional behavior. The proposed change allows comma elision only in expression lists.
|
Trying to build a toolchain with this feature and static subscripts. |
Enables newlines to be used in place of separators in some lists.