This repository has been archived by the owner on Apr 13, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 787
increased strictness of types #695
Merged
Merged
Changes from 7 commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
fa0e148
increased strictness of typescript types
e7be433
add mutation to default child props
6708871
lock ts version to greater than 2.3.0 and set state to be {}
14a08fb
fix lint error
e652e08
lock jest to 19 for now
e30b834
added flow typings! TODO remove AC typings after they are tested and …
f7a5282
Merge branch 'master' into types-rewrite
52811e8
more strict types for server code and a few flow tweaks
658cb88
Merge branch 'types-rewrite' of https://github.com/apollostack/react-…
9ee0cc5
support bundled flow types
401f604
change options name to fix AC collision and add flow smoke test
a36c853
Merge branch 'master' into types-rewrite
9bc9367
lock RN versions
e95593c
version bump uglify
eb4e0c0
fix uglify command
308316c
Merge branch 'master' into types-rewrite
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this will be a breaking change for TS devs, right? Might be worth a mention in the changelog.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@stubailo for sure! I'll add that and note it in the release as well