Skip to content
This repository has been archived by the owner on Apr 13, 2023. It is now read-only.

Fix server side rendering when using the cache-and-network fetchPolicy #688

Merged
merged 2 commits into from
May 4, 2017

Conversation

amannn
Copy link
Contributor

@amannn amannn commented May 4, 2017

As discussed in #328.

I've added a test that passes now with the adapted logic in graphql.tsx. I'm not quite confident if it is the right way to go though, so I'd appreciate a review 🙂.

TODO:

  • If this PR is a new feature, reference an issue where a consensus about the design was reached (not necessary for small changes)
  • Make sure all of the significant new logic is covered by tests
  • Rebase your changes on master so that they can be merged easily
  • Make sure all tests and linter rules pass
  • Update CHANGELOG.md with your change
  • If this was a change that affects the external API, update the docs and post a link to the PR in the discussion

@jbaxleyiii jbaxleyiii merged commit 1452b3c into apollographql:master May 4, 2017
@jbaxleyiii
Copy link
Contributor

@amannn this is great! Thank you!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants