This repository has been archived by the owner on Apr 13, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 787
Re-export everything from apollo-client #650
Merged
Merged
Changes from 1 commit
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,10 +1,9 @@ | ||
export { default as ApolloProvider } from './ApolloProvider'; | ||
export { default as graphql, withApollo, InjectedGraphQLProps } from './graphql'; | ||
|
||
|
||
// expose easy way to join queries from redux | ||
export { compose } from 'redux'; | ||
|
||
// re-exports of close dependencies. | ||
export { default as ApolloClient, createNetworkInterface, createBatchingNetworkInterface } from 'apollo-client'; | ||
export * from 'apollo-client'; | ||
export { default as gql } from 'graphql-tag'; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,3 @@ | ||
export * from './browser'; | ||
|
||
export { getDataFromTree, renderToStringWithData } from './server'; | ||
|
||
export { default as ApolloClient, createNetworkInterface, createBatchingNetworkInterface } from 'apollo-client'; | ||
export { default as gql } from 'graphql-tag'; |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will that export the default as ApolloClient? We should make sure that's the case. Otherwise we should just list all the things that we want to export. It's okay if there are a few things missing occasionally, because people can always import directly from apollo-client as a workaround.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ApolloClient
is also a named export fromapollo-client
(as well as the default export) so it should make no difference.Ref: https://github.com/apollographql/apollo-client/blob/master/src/index.ts#L121