Skip to content
This repository has been archived by the owner on Apr 13, 2023. It is now read-only.

Re-export everything from apollo-client #650

Merged
merged 3 commits into from
Apr 28, 2017
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/browser.ts
Original file line number Diff line number Diff line change
@@ -1,10 +1,9 @@
export { default as ApolloProvider } from './ApolloProvider';
export { default as graphql, withApollo, InjectedGraphQLProps } from './graphql';


// expose easy way to join queries from redux
export { compose } from 'redux';

// re-exports of close dependencies.
export { default as ApolloClient, createNetworkInterface, createBatchingNetworkInterface } from 'apollo-client';
export * from 'apollo-client';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will that export the default as ApolloClient? We should make sure that's the case. Otherwise we should just list all the things that we want to export. It's okay if there are a few things missing occasionally, because people can always import directly from apollo-client as a workaround.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ApolloClient is also a named export from apollo-client (as well as the default export) so it should make no difference.

Ref: https://github.com/apollographql/apollo-client/blob/master/src/index.ts#L121

export { default as gql } from 'graphql-tag';
3 changes: 0 additions & 3 deletions src/index.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,3 @@
export * from './browser';

export { getDataFromTree, renderToStringWithData } from './server';

export { default as ApolloClient, createNetworkInterface, createBatchingNetworkInterface } from 'apollo-client';
export { default as gql } from 'graphql-tag';