Skip to content
This repository has been archived by the owner on Apr 13, 2023. It is now read-only.

Re-export everything from apollo-client #650

Merged
merged 3 commits into from
Apr 28, 2017

Conversation

bensalilijames
Copy link
Contributor

Fixes #521. :)

TODO:

  • If this PR is a new feature, reference an issue where a consensus about the design was reached (not necessary for small changes)
  • Make sure all of the significant new logic is covered by tests
  • Rebase your changes on master so that they can be merged easily
  • Make sure all tests and linter rules pass
  • Update CHANGELOG.md with your change
  • If this was a change that affects the external API, update the docs and post a link to the PR in the discussion

@apollo-cla
Copy link

@benhjames: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/

@thebigredgeek
Copy link
Contributor

@helfer lgtm. thoughts?

// expose easy way to join queries from redux
export { compose } from 'redux';

// re-exports of close dependencies.
export { default as ApolloClient, createNetworkInterface, createBatchingNetworkInterface } from 'apollo-client';
export * from 'apollo-client';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will that export the default as ApolloClient? We should make sure that's the case. Otherwise we should just list all the things that we want to export. It's okay if there are a few things missing occasionally, because people can always import directly from apollo-client as a workaround.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ApolloClient is also a named export from apollo-client (as well as the default export) so it should make no difference.

Ref: https://github.com/apollographql/apollo-client/blob/master/src/index.ts#L121

Copy link
Contributor

@helfer helfer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I'm convinced.

@helfer helfer merged commit 8dd277d into apollographql:master Apr 28, 2017
@bensalilijames bensalilijames deleted the fix-exports branch April 28, 2017 10:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants