-
Notifications
You must be signed in to change notification settings - Fork 787
Re-export everything from apollo-client #650
Conversation
@benhjames: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/ |
@helfer lgtm. thoughts? |
// expose easy way to join queries from redux | ||
export { compose } from 'redux'; | ||
|
||
// re-exports of close dependencies. | ||
export { default as ApolloClient, createNetworkInterface, createBatchingNetworkInterface } from 'apollo-client'; | ||
export * from 'apollo-client'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will that export the default as ApolloClient? We should make sure that's the case. Otherwise we should just list all the things that we want to export. It's okay if there are a few things missing occasionally, because people can always import directly from apollo-client as a workaround.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ApolloClient
is also a named export from apollo-client
(as well as the default export) so it should make no difference.
Ref: https://github.com/apollographql/apollo-client/blob/master/src/index.ts#L121
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, I'm convinced.
Fixes #521. :)
TODO: