This repository has been archived by the owner on Apr 13, 2023. It is now read-only.
fix: ssr should support network-only & cache-and-network fetchPolicies. disabled ssr queries were still issuing requests #3435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s. disabling ssr queries were still issuing the requests
mikebm
changed the title
mikebm
changed the title
mikebm
commented
Aug 30, 2019
| } | ||
| } | ||
|
|
||
| private updateObservableQuery() { | ||
| // If we skipped initially, we may not have yet created the observable | ||
| if (!this.currentObservable.query) { | ||
| this.initializeObservableQuery(); | ||
| return; |
There was a problem hiding this comment.
this was added as an optimization. updating the options doesn't need to happen because it was just initialized.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to issues discovered in topic #3338
Might be related to #3390
This PR addresses 2 issues and some cleanup.
Issue 1)
network-onlyfetchPolicy during a SSR was resulting in the component being stuck in a loading state.Issue 2) Disabling a query using
ssr:falsewould result in the query still being executed on the server even though it was never used.Cleanup:
GetOptions returns new objects with each call. This PR will reduce the amount of times it is called and thus reduces some garbage. In addition, with the changes on where the SSR observable was initialize, fetchData was greatly reduced in needed code.