This repository has been archived by the owner on Apr 13, 2023. It is now read-only.
Allow MockedResponse results to be returned from a function
#2788
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `result` property of a `MockedResponse` is currently restricted to being a pre-configured fixed value. Allowing results to be calculated/returned from a function instead of being pre-configured, opens up new test verification paths, that can be useful when using `MockedProvider`. This commit adjusts `MockedResponse`’s `result` such that if a function is set for its value, that function will be fired and its result will be passed to the Observable matching the incoming mocked `request`. Fixes apollographql/apollo-feature-requests#84.
hwillson
force-pushed
the
hwillson/fr-84
branch
from
5a15e9e to
f174574
Compare
benjamn
approved these changes
Feb 8, 2019
Co-Authored-By: hwillson <hugh@octonary.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
resultproperty of aMockedResponseis currently restricted to being a pre-configured fixed value. Allowing results to be calculated/returned from a function instead of being pre-configured, opens up new test verification paths, that can be useful when usingMockedProvider.This PR adjusts
MockedResponse’sresultsuch that if a function is set for its value, that function will be fired and its result will be passed to the Observable matching the incoming mockedrequest.Fixes apollographql/apollo-feature-requests#84.