-
Notifications
You must be signed in to change notification settings - Fork 787
Conversation
Generated by 🚫 dangerJS |
@jbaxleyiii I just wanted to say that it took me about 15 minutes to upgrade Thank you so much for all your work! 💯 |
@stevewillard that is SO great to hear! Please let me know if you run into anything odd! |
Does it still depend on redux store? Is there any love for mobx? And how do I check if queries have finished running? I need it for my testing tools. Thanks! Great job! |
It seems |
Is ErrorPolicy planned for this release? |
#890 is still an issue |
@jbaxleyiii When will this be pushed to NPM for testing? |
We're still having major performance issues with Apollo 2.0 and React Native when adding 100s of items to the store. Just trying to star a player takes ages. We sat days working on it optimising as much as possible, but the only solution on Apollo 1.0 was to not load these items into the store. Apollo 2.0 is just as bad performance wise for us. |
I am unable to figure out an upgrade process here. Just got the 2.0 via an
The claim in this PR that this change is not a breaking change is incorrect based on these observations. |
Should README.md be changed too? From this:
to this:
Do we really need to import the client from react-apollo or this would be fine:
|
what is the status of react-apollo 2 ? |
@jbaxleyiii |
tldr;
The 2.0 upgrade is 100% backwards compat with the 1.0! The only change is upgrading apollo-client which does have some minor breaking changes. Oh its also 2/3 the size of the 1.0 🎉
Roadmap
Included in this PR is a roadmap for what is next for react-apollo. PLEASE comment on this PR (it will stay open until the 2.0 for apollo-client is live) with feedback!
This PR is to upgrade to apollo-client 2.0 which is a breaking change for this library since it directly exported the client. Going forward, react-apollo will no longer directly export
gql
orapollo-client
to prevent this semver lock in.