Skip to content
This repository has been archived by the owner on Apr 13, 2023. It is now read-only.

this.queryHandles keys refers to query options instead of actual WatchedQueryHandle #8

Closed
lgollut opened this issue Apr 18, 2016 · 1 comment · Fixed by #9
Closed

Comments

@lgollut
Copy link

lgollut commented Apr 18, 2016

mapQueriesToProps seems to be initially designed to call watchQuery(options) in bde5a2c but is implemented without passing the function. this.queryHandles hence only contains queries options and unsubcribeAllQueries() fails on this.queryHandles[key].stop()

@jbaxleyiii
Copy link
Contributor

jbaxleyiii commented Apr 19, 2016

@lgollut we actually changed the API and removed the watchQuery as part of the argument object. Curious, what do you need the handle for?

I'll fix that oversight though and add a test for it

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants