withMutation should support loading/error/called/data states

[slikts]

Previous (closed) issues: #421 #1842

The graphql() (and withMutation()) HOCs currently have a surprising limitation in that the mutation results aren't passed by them, which isn't explained by the docs, and there also isn't an obvious reason for it. The natural expectation from reading the docs would be that HOCs and components would have feature parity (despite HOCs having fallen by the wayside to render props and more recently hooks) and would just be alternative APIs for the same functionality, especially since graphql() delegates to components under the hood. In other words, passing mutation results in withMutation() would follow the principle of least surprise.

The answer also shouldn't be "just use components or hooks"; the reason to pick HOCs currently is that components suffer from "wrapper hell" unless a helper library like react-adopt is used, and that hooks are still immature.

[cihadturhan]

I prefer using HOC over components and hooks. With HOC, I can easily separate query/mutate logic from view, especially using with decorators

@graphql(MY_CANDIDATES_AND_PRIMARY, { name: "myCandidatesQuery" })
@graphql(CANDIDATES, { name: "candidatesQuery" })
@graphql(UPDATE_CANDIDATES, { name: "updateCandidatesMutation" })
class CandidatesListScreen extends Component {
   //...
}

However, I can't get why there is no variables provided like queries.

[rwoody]

I have the same problem when wrapping my components with graphql. Isn't this a regression? I thought I remembered mutations triggering loading and error props...

[slikts]

Yes; it is (was) a regression and is fixed by #3008 (not sure in which release the changes are in).

Closing this ticket as a duplicate of #1967

[rwoody]

Thanks you!

…

On Wed, Jun 12, 2019 at 4:50 AM slikts ***@***.***> wrote: Yes; it is (was) a regression and is fixed by #3008 <#3008> (not sure in which release the changes are in). Closing this ticket as a duplicate of #1967 <#1967> — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#2952?email_source=notifications&email_token=AAHIAKS3GW42HR22MF6KNTLP2DBHVA5CNFSM4HFDCS62YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXP3ZDI#issuecomment-501202061>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAHIAKRAMZJOVXTCLY2YV53P2DBHVANCNFSM4HFDCS6Q> .