Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SPM Codegen missing omitDeprecatedEnumCases #1052

Closed
wow-such-amazing opened this issue Feb 29, 2020 · 3 comments
Closed

SPM Codegen missing omitDeprecatedEnumCases #1052

wow-such-amazing opened this issue Feb 29, 2020 · 3 comments
Assignees
@designatednerd
Labels
codegen Issues related to or arising from code generation
Milestone
0.23.2

Comments

@wow-such-amazing
Copy link
Contributor

Hi 👋

I decided to try Codegen via SPM and I think it misses argument omitDeprecatedEnumCases in ApolloCodegenOptions. Or maybe I didn't find a way to pass this option to Codegen 🤔

Thank you :)
@designatednerd
Copy link
Contributor

Aha! good catch, I think that was added to the typescript codegen after I wrote most of the stuff in the swift codegen. Will add

@designatednerd designatednerd self-assigned this Feb 29, 2020
@designatednerd designatednerd added the codegen Issues related to or arising from code generation label Feb 29, 2020
@designatednerd designatednerd mentioned this issue Feb 29, 2020
Merged
@designatednerd designatednerd added this to the Next Release milestone Feb 29, 2020
@designatednerd
Copy link
Contributor

Merged - you can grab this on master right now if you want but it'll go out in the next release (probably monday or tuesday)

@wow-such-amazing
Copy link
Contributor Author

That’s awesome, thank you 🙌🏼

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@designatednerd designatednerd

Labels
codegen Issues related to or arising from code generation
Projects
None yet
Milestone
0.23.2
Development

No branches or pull requests
2 participants
@designatednerd @wow-such-amazing