fix: Ensure plain text response is only used for strings (#29)

Author: mattbearman

lib/apia/definitions/error.rb

@@ -37,7 +37,7 @@ def http_status_code
       # API.
       #
       # @param errors [Apia::ManifestErrors]
-      # @reeturn [void]
+      # @return [void]
       def validate(errors)
         unless code.is_a?(Symbol)
           errors.add self, 'InvalidCode', 'Code must be a symbol'

lib/apia/response.rb

@@ -70,11 +70,14 @@ def body
     #
     # @return [Array]
     def rack_triplet
-      case @type
-      when JSON
-        Rack.json_triplet(body, headers: headers, status: status)
-      when PLAIN
+      # Errors will always be sent as a hash intended for JSON encoding,
+      # even if the endpoint specifies a plain text response, so only
+      # send a pain response if the type is plaintext _and_ the body is
+      # a string
+      if @type == PLAIN && body.is_a?(String)
         Rack.plain_triplet(body, headers: headers, status: status)
+      else
+        Rack.json_triplet(body, headers: headers, status: status)
       end
     end
 

spec/specs/apia/response_spec.rb

@@ -135,6 +135,14 @@
         expect(response.rack_triplet[2][0]).to eq 'hello world'
         expect(response.rack_triplet[1]['content-length']).to eq '11'
       end
+
+      it 'should return JSON if the body is not a string' do
+        response = Apia::Response.new(request, endpoint)
+        response.body = { hello: 'world' }
+        expect(response.rack_triplet[1]['content-type']).to eq 'application/json'
+        expect(response.rack_triplet[1]['content-length']).to eq '17'
+        expect(response.rack_triplet[2][0]).to eq '{"hello":"world"}'
+      end
     end
 
     context 'with a legacy plain text response' do