Migrate to typescript #757
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
dangreen
requested changes
Mar 14, 2022
There was a problem hiding this comment.
- What about tests, stories, etc?
- Please remove https://github.com/apertureless/vue-chartjs/tree/main/types
- Let's add tests for types (e. g. https://github.com/reactchartjs/react-chartjs-2/blob/master/test/chart.test-d.tsx, https://github.com/SamVerschueren/tsd)
.eslintrc.js
Outdated
| LIB_VERSION: true, | ||
| }, | ||
| }; | ||
| LIB_VERSION: true |
There was a problem hiding this comment.
there is no global var with this name
There was a problem hiding this comment.
Added Typescript to stories, sandboxes, tests. Added test for types definition. Removed unused vars and folders
add typescript and change project configs BREAKING CHANGE: add typescript
thabarbados
force-pushed
the
migrate-to-typescript
branch
from
67b2c57 to
39c52e8
Compare
dangreen
requested changes
Mar 16, 2022
.clean-publish
Outdated
| "tempDir": "package" | ||
| "tempDir": "package", | ||
| "fields": ["tsd"], | ||
| "files": ["website"] |
There was a problem hiding this comment.
Suggested change
| "files": ["website"] | |
| "files": ["docs"] |
| @@ -26,3 +26,25 @@ jobs: | |||
| uses: andresz1/size-limit-action@master | |||
| with: | |||
| github_token: ${{ secrets.GITHUB_TOKEN }} | |||
| typings: | |||
There was a problem hiding this comment.
please add check for storybook https://github.com/reactchartjs/react-chartjs-2/blob/master/.github/workflows/checks.yml#L48
dangreen
approved these changes
Mar 16, 2022
dangreen
pushed a commit
that referenced
this pull request
Mar 17, 2022
* chore: add typescript add typescript and change project configs BREAKING CHANGE: add typescript * refactor: rewrite code to typescript * fix: change interface name * feat: remove unused global var * feat: remove old types folder * feat: add eslintignore * feat: add typescript to sandboxes * feat: rewrite stories to typescript * feat: rewrite tests to typescript * feat: fix app exports and props types * feat: add tests for type definitions * fix: fix clean-publish config * fix: fix clean-publish config again * feat: add storybook build check
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix or Enhancement?
Add typescript and rewrite code
Environment