Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #9191] Provide the ability to replace the remoting layer implementation for Proxy and Broker #9192

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

f1amingo
Copy link
Contributor

@f1amingo f1amingo commented Feb 19, 2025

Which Issue(s) This PR Fixes

Fixes #9191

Brief Description

Provide the ability to replace the remoting layer implementation for Proxy and Broker.
This allows us to implement custom RemotingClient and RemotingServer to support a variety of network protocols.

How Did You Test This Change?

The existing test cases can cover most of the modifications. For the parts not covered by the existing test cases, I have added new test cases.

@codecov-commenter
Copy link

codecov-commenter commented Feb 19, 2025

Codecov Report

Attention: Patch coverage is 78.98551% with 29 lines in your changes missing coverage. Please review.

Project coverage is 48.09%. Comparing base (98308f6) to head (107ac8e).
Report is 2 commits behind head on develop.

Files with missing lines Patch % Lines
...a/org/apache/rocketmq/broker/BrokerController.java 82.79% 11 Missing and 5 partials ⚠️
...ketmq/client/impl/mqclient/MQClientAPIFactory.java 0.00% 5 Missing ⚠️
.../rocketmq/proxy/service/ClusterServiceManager.java 0.00% 3 Missing ⚠️
.../rocketmq/proxy/service/ServiceManagerFactory.java 0.00% 3 Missing ⚠️
...rocketmq/remoting/netty/NettyRemotingAbstract.java 0.00% 1 Missing ⚠️
...e/rocketmq/remoting/netty/NettyRemotingClient.java 87.50% 1 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #9192      +/-   ##
=============================================
- Coverage      48.15%   48.09%   -0.06%     
+ Complexity     12112    12106       -6     
=============================================
  Files           1321     1321              
  Lines          93030    93065      +35     
  Branches       11923    11929       +6     
=============================================
- Hits           44796    44764      -32     
- Misses         42715    42776      +61     
- Partials        5519     5525       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@f1amingo f1amingo force-pushed the remoting_replacement branch from 0ad9d90 to 09c7150 Compare February 21, 2025 05:48
@f1amingo f1amingo force-pushed the remoting_replacement branch from 09c7150 to 120a417 Compare February 21, 2025 05:55
@f1amingo f1amingo requested a review from RongtongJin February 21, 2025 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] Provide the ability to replace the remoting layer implementation for Proxy and Broker
3 participants