Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ISSUE #9188] Use fastjson2 in org/apache/rocketmq/broker/config/v1 #9189

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

[ISSUE #9188] Use fastjson2 in org/apache/rocketmq/broker/config/v1 #9189

wants to merge 1 commit into from

Conversation

yx9o
Copy link
Contributor

@yx9o yx9o commented Feb 17, 2025

Fixes #9188 .

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 48.01%. Comparing base (98308f6) to head (832f894).

Files with missing lines Patch % Lines
...ker/config/v1/RocksDBSubscriptionGroupManager.java 50.00% 1 Missing ⚠️
Additional details and impacted files 
@@              Coverage Diff              @@
##             develop    #9189      +/-   ##
=============================================
- Coverage      48.14%   48.01%   -0.13%     
+ Complexity     12108    12077      -31     
=============================================
  Files           1321     1321              
  Lines          93030    93030              
  Branches       11923    11923              
=============================================
- Hits           44787    44671     -116     
- Misses         42720    42825     +105     
- Partials        5523     5534      +11

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ltamber
Copy link
Contributor

ltamber commented Feb 19, 2025

Can the deps @maven//:com_alibaba_fastjson in the BUILD.bazel file of the broker module be removed?

@yx9o
Copy link
Contributor Author

yx9o commented Feb 19, 2025

Can the deps @maven//:com_alibaba_fastjson in the BUILD.bazel file of the broker module be removed?

Cannot delete yet, some fastjson has not been replaced yet, need to be tested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ltamber ltamber ltamber approved these changes

@RongtongJin RongtongJin RongtongJin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Enhancement] Use fastjson2 in org/apache/rocketmq/broker/config/v1
4 participants
@yx9o @codecov-commenter @ltamber @RongtongJin