Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MNG-8611] Build with apache-release profile #2146

Merged
merged 3 commits into from
Mar 5, 2025
Merged

[MNG-8611] Build with apache-release profile #2146

merged 3 commits into from
Mar 5, 2025
+10 −10

Conversation

gnodet
Copy link
Contributor

@gnodet gnodet commented Mar 5, 2025 •
edited
Loading

JIRA issue: MNG-8611

@gnodet gnodet changed the title Build with apache-release profile [MNG-8611] Build with apache-release profile Mar 5, 2025
@gnodet gnodet added this to the 4.0.0-rc-3 milestone Mar 5, 2025
@gnodet gnodet force-pushed the javadoc-release branch from c5d2460 to a508ed4 Compare March 5, 2025 08:44
michael-o
michael-o requested changes Mar 5, 2025
View reviewed changes
Copy link
Member

@michael-o michael-o left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Contains unrelated changes

@gnodet
Copy link
Contributor Author

gnodet commented Mar 5, 2025 •
edited
Loading

Contains unrelated changes

@michael-o The first two commits are a test to make sure the problem is caught and that CI actually fails.

The problem is actually {@link } between reactor dependencies. The site build does not catch those problems, as the javadoc aggregates all modules together.

@gnodet gnodet requested a review from cstamas March 5, 2025 09:06
@gnodet gnodet requested a review from michael-o March 5, 2025 09:36
@gnodet gnodet merged commit ab102fb into apache:master Mar 5, 2025
13 checks passed
@michael-o
Copy link
Member

Contains unrelated changes

@michael-o The first two commits are a test to make sure the problem is caught and that CI actually fails.

The problem is actually {@link } between reactor dependencies. The site build does not catch those problems, as the javadoc aggregates all modules together.

OK, I see. Then it makes sense. It looked totally unrelated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cstamas cstamas cstamas approved these changes

@michael-o michael-o Awaiting requested review from michael-o

Assignees

@gnodet gnodet

Labels
maintenance
Projects
None yet
Milestone
4.0.0-rc-3
Development

Successfully merging this pull request may close these issues.
3 participants
@gnodet @michael-o @cstamas