[MNG-8605] The log file should be appended to #2137
Conversation
gnodet
changed the title
| @@ -231,7 +231,7 @@ private static OutputChoice computeOutputChoice(String logFile, boolean cacheOut | |||
| return new OutputChoice(cacheOutputStream ? OutputChoiceType.CACHED_SYS_OUT : OutputChoiceType.SYS_OUT); | |||
| } else { | |||
| try { | |||
| FileOutputStream fos = new FileOutputStream(logFile); | |||
| FileOutputStream fos = new FileOutputStream(logFile, true); | |||
There was a problem hiding this comment.
Why?
It's a log, the point is to get information, not to loose it. If you don't need the log, just remove it.
There was a problem hiding this comment.
The problem I had was debugging a test in mvnd which runs Maven twice in a row. It took me some time to find out why I only had the output of the second run in the log...
No big deal though.
There was a problem hiding this comment.
Well, this sounds like a mvnd problem, not?
There was a problem hiding this comment.
So mvnd uses the Constants.MAVEN_LOGGER_LOG_FILE constant to make sure the daemon log is redirected to disk, see https://github.com/apache/maven-mvnd/blob/db22a0a31bdcb000542a80c7d0ec491eab77f0bf/client/src/main/java/org/mvndaemon/mvnd/client/DaemonConnector.java#L437-L438
This means that only the last execution for a given daemon will be logged. I don't really see that as an intuitive behavior, as the daemon aims at being reused, so the log should not be erased imho. If you're not happy with changing the default, I'm fine with adding another property if you prefer. Note that in stock maven, this property is actually mostly useless, as it's being circumvented by another mechanism (you need a custom ProjectBuildLogAppender to get around that, such as in mvnd).
|
You didn't even leave time to respond...😥 |
JIRA issue: MNG-8605