Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dubbo-3741]Remove extra tags #3742

Merged
merged 1 commit into from
Mar 27, 2019
Merged

[Dubbo-3741]Remove extra tags #3742

merged 1 commit into from
Mar 27, 2019

Conversation

mawenlong1
Copy link
Contributor

What is the purpose of the change

Remove extra tags #3741

Brief changelog

XXXXX

Verifying this change

XXXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@fb0fd60). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##             master   #3742   +/-   ##
========================================
  Coverage          ?   63.5%           
  Complexity        ?      71           
========================================
  Files             ?     704           
  Lines             ?   31069           
  Branches          ?    5022           
========================================
  Hits              ?   19731           
  Misses            ?    9057           
  Partials          ?    2281

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb0fd60...f52869f. Read the comment docs.

@CrazyHZM CrazyHZM merged commit c11df93 into apache:master Mar 27, 2019
@CrazyHZM
Copy link
Member

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants