Skip to content

Commit db68fc8

Browse files
authoredJul 20, 2023
refactor: add grpc query nums metrics (#1090)
## Rationale See title ## Detailed Changes - Add query nums metric in grpc proxy. - Add query nums metric in grpc remote engine service. ## Test Plan Existing tests
1 parent 6c1e72c commit db68fc8

File tree

4 files changed

+6
-2
lines changed

4 files changed

+6
-2
lines changed
 

‎proxy/src/grpc/sql_query.rs

+2
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,7 @@ const STREAM_QUERY_CHANNEL_LEN: usize = 20;
3737

3838
impl<Q: QueryExecutor + 'static> Proxy<Q> {
3939
pub async fn handle_sql_query(&self, ctx: Context, req: SqlQueryRequest) -> SqlQueryResponse {
40+
GRPC_HANDLER_COUNTER_VEC.query.inc();
4041
self.hotspot_recorder.inc_sql_query_reqs(&req).await;
4142
match self.handle_sql_query_internal(ctx, req).await {
4243
Err(e) => {
@@ -80,6 +81,7 @@ impl<Q: QueryExecutor + 'static> Proxy<Q> {
8081
ctx: Context,
8182
req: SqlQueryRequest,
8283
) -> BoxStream<'static, SqlQueryResponse> {
84+
GRPC_HANDLER_COUNTER_VEC.stream_query.inc();
8385
self.hotspot_recorder.inc_sql_query_reqs(&req).await;
8486
match self.clone().handle_stream_query_internal(ctx, req).await {
8587
Err(e) => stream::once(async {

‎proxy/src/metrics.rs

+2
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,10 @@ make_auto_flush_static_metric! {
1212
write_failed,
1313
query_succeeded,
1414
query_failed,
15+
query,
1516
stream_query_succeeded,
1617
stream_query_failed,
18+
stream_query,
1719
write_succeeded_row,
1820
write_failed_row,
1921
query_succeeded_row,

‎server/src/grpc/metrics.rs

+1-2
Original file line numberDiff line numberDiff line change
@@ -38,8 +38,7 @@ make_auto_flush_static_metric! {
3838
pub label_enum RemoteEngineGrpcTypeKind {
3939
write_succeeded,
4040
write_failed,
41-
query_succeeded,
42-
query_failed,
41+
stream_query,
4342
stream_query_succeeded,
4443
stream_query_failed,
4544
write_succeeded_row,

‎server/src/grpc/remote_engine_service/mod.rs

+1
Original file line numberDiff line numberDiff line change
@@ -235,6 +235,7 @@ impl<Q: QueryExecutor + 'static> RemoteEngineService for RemoteEngineServiceImpl
235235
&self,
236236
request: Request<ReadRequest>,
237237
) -> std::result::Result<Response<Self::ReadStream>, Status> {
238+
REMOTE_ENGINE_GRPC_HANDLER_COUNTER_VEC.stream_query.inc();
238239
match self.stream_read_internal(request).await {
239240
Ok(stream) => {
240241
let new_stream: Self::ReadStream = Box::pin(stream.map(|res| match res {

0 commit comments

Comments
 (0)
Please sign in to comment.