Skip to content

Commit 22b724c

Browse files
authored
fix: ensure channel size non zero (#1345)
## Rationale When channel capacity < read_parallelism, we will pass 0 to channel, which will cause panic ``` 2023-12-05 20:31:32.974 ERRO [components/panic_ext/src/lib.rs:54] thread 'ceres-read' panicked 'mpsc bounded channel requires buffer > 0' at "analytic_engine/src/sst/parquet/async_reader.rs:736" ``` ## Detailed Changes - Ensure channel size non zero ## Test Plan No need.
1 parent 3bf05ff commit 22b724c

File tree

2 files changed

+2
-1
lines changed

2 files changed

+2
-1
lines changed

analytic_engine/src/sst/parquet/async_reader.rs

+1
Original file line numberDiff line numberDiff line change
@@ -732,6 +732,7 @@ impl<'a> SstReader for ThreadedReader<'a> {
732732
);
733733

734734
let channel_cap_per_sub_reader = self.channel_cap / sub_readers.len();
735+
let channel_cap_per_sub_reader = channel_cap_per_sub_reader.max(1);
735736
let (tx_group, rx_group): (Vec<_>, Vec<_>) = (0..read_parallelism)
736737
.map(|_| mpsc::channel::<Result<RecordBatchWithKey>>(channel_cap_per_sub_reader))
737738
.unzip();

integration_tests/build_meta.sh

+1-1
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ META_BIN_PATH=${META_BIN_PATH:-""}
88

99
if [[ -z "${META_BIN_PATH}" ]]; then
1010
echo "Fetch and install ceresmeta-server..."
11-
go install -a github.com/CeresDB/horaemeta/cmd/ceresmeta-server@main
11+
go install -v -a github.com/CeresDB/ceresmeta/cmd/ceresmeta-server@dev
1212
META_BIN_PATH="$(go env GOPATH)/bin/ceresmeta-server"
1313
fi
1414

0 commit comments

Comments
 (0)