Skip to content

[#6920] docs(docs): Add doc to Model update #6921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 51 commits into from
Apr 22, 2025

Conversation

Abyss-lord
Copy link
Collaborator

What changes were proposed in this pull request?

Add doc to Model update. Except for Update Comment, this needs to wait for PR merging.

Why are the changes needed?

Fix: #6920

Does this PR introduce any user-facing change?

Add docs of Model update .

How was this patch tested?

local test.

@Abyss-lord Abyss-lord self-assigned this Apr 14, 2025
@Abyss-lord
Copy link
Collaborator Author

Hi @jerryshao , could you please review this PR when you have time? I’d really appreciate your feedback.

@jerqi jerqi added the branch-0.9 Automatically cherry-pick commit to branch-0.9 label Apr 14, 2025
fix docs

Co-authored-by: Qiming Teng <tengqm@outlook.com>
@Abyss-lord Abyss-lord requested a review from tengqm April 14, 2025 12:56
@Abyss-lord
Copy link
Collaborator Author

Hi @tengqm @jerryshao , I've completed the code updates and would appreciate your review of the PR when you have a moment. Here's a summary of the commits:

  1. Fix docs.

@Abyss-lord Abyss-lord requested review from tengqm and jerryshao April 14, 2025 16:28
mchades and others added 9 commits April 16, 2025 00:13
…module (apache#6922)

### What changes were proposed in this pull request?

support fileset multiple locations in the core and catalog module

### Why are the changes needed?

Fix: apache#6892

### Does this PR introduce _any_ user-facing change?

no

### How was this patch tested?

tests added
…failed with krb cluster for iceberg issue (apache#6873)

### What changes were proposed in this pull request?

Fix use catalog and show databases failed with krb cluster for iceberg
issue

### Why are the changes needed?

Fix: apache#6871


### Does this PR introduce _any_ user-facing change?
No

### How was this patch tested?
local test.
steps:
1、curl -X POST -H "Accept: application/vnd.gravitino.v1+json"
-H "Content-Type: application/json" -d '{
"name": "iceberg_catalog",
"type": "RELATIONAL",
"comment": "iceberg catalog",
"provider": "lakehouse-iceberg",
"properties": {
"catalog-backend": "hive",
"warehouse": "/pathforhivetest",
"uri": "thrift://HMS HOST:9083",
"gravitino.bypass.hadoop.security.authentication": "kerberos",
"gravitino.bypass.hive.metastore.sasl.enabled": "true",
"gravitino.bypass.hive.metastore.kerberos.principal": "hive/HMS
HOST@REALM",
"authentication.kerberos.keytab-uri": "PATH OF KEYTAB",
"authentication.kerberos.principal": "hive/HOST INSATANCE@REALM",
"authentication.type": "kerberos",
"authentication.impersonation-enable": true
}
}' http://localhost:8090/api/metalakes/dev_metalake/catalogs

2、
spark-sql -v --conf
spark.plugins="org.apache.gravitino.spark.connector.plugin.GravitinoSparkPlugin"
--conf spark.sql.gravitino.uri=http://localhost:8090/ --conf
spark.sql.gravitino.metalake=dev_metalake --conf
spark.sql.gravitino.enableIcebergSupport=true --conf
spark.sql.warehouse.dir=xxxx --conf
spark.sql.gravitino.authType=kerberos --conf
spark.kerberos.principal=user1/[xxxxxx@MY.HADOOP--conf](mailto:xxxxxx@MY.HADOOP--conf)
spark.kerberos.keytab=/user1.keytab

3、use iceberg_catalog;show database

![image](https://github.com/user-attachments/assets/92b9a581-0cb2-45d3-b554-681adea9150f)
### What changes were proposed in this pull request?

Support lineage sinks, Linkage sinks manager will load all linkage sinks
and register them as event listeners.

### Why are the changes needed?

Fix: apache#6781 

### Does this PR introduce _any_ user-facing change?
no

### How was this patch tested?

1. add UT
2. setup a local environment to test spark linage
…T API (apache#6924)

### What changes were proposed in this pull request?

support fileset multiple locations in REST API

### Why are the changes needed?

support fileset multiple locations in REST API

Fix: apache#6893 

### Does this PR introduce _any_ user-facing change?

yes

### How was this patch tested?

tests added
…iple locations (apache#6935)

### What changes were proposed in this pull request?

Java/Python clients supports fileset multiple locations

### Why are the changes needed?

Fix: apache#6894

### Does this PR introduce _any_ user-facing change?

yes, Java/Python clients support fileset multiple locations

### How was this patch tested?

tests added
apache#6937)

### What changes were proposed in this pull request?

support specifying the location name in GVFS

### Why are the changes needed?

since the fileset supports multiple locations, the GVFS should support
to specify the location when preforming FS ops

Fix: apache#6895


### Does this PR introduce _any_ user-facing change?

yes

### How was this patch tested?

tests added
…pache#6861)

Support update comment for model version

- [x] PR1: Add ModelVersionChange API interface, Implement the update
comment logic in model catalog and JDBC backend logic, update related
event.
- [ ] PR2: Add REST endpoint to support model version change, add Java
client and Python client for model version comment update.

Fix: apache#6815

User can update  the comment of a model version.

local test.

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: roryqi <he@datastrato.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Jerry Shao <jerryshao@datastrato.com>
Co-authored-by: yangyang zhong <35210666+hdygxsj@users.noreply.github.com>
Co-authored-by: FANNG <xiaojing@datastrato.com>
Co-authored-by: Eric Chang <e850506@gmail.com>
Co-authored-by: Mini Yu <yuqi@datastrato.com>
Co-authored-by: mchades <liminghuang@datastrato.com>
@tengqm
Copy link
Collaborator

tengqm commented Apr 15, 2025

/lgtm

@Abyss-lord
Copy link
Collaborator Author

Abyss-lord commented Apr 16, 2025

/lgtm

Thx, @jerryshao plz help to check this PR when you have time.

@jerryshao
Copy link
Contributor

I would suggest to have doc merged in the last moment. Before that, we'd better hurry up to merge other left PRs for model/model version alteration as possible as we can.

@Abyss-lord
Copy link
Collaborator Author

Abyss-lord commented Apr 16, 2025

I would suggest to have doc merged in the last moment. Before that, we'd better hurry up to merge other left PRs for model/model version alteration as possible as we can.

@jerryshao I will complete the Model Version update as soon as possible, but at the moment, it seems that only the PR for updating the Model Version comment can be merged. As for the PR related to updating the Model comment, I'm not sure if @TEOTEO520 will be able to finish it before the code is freeze. Personally, I would like to complete the entire Model update feature in version 0.9, although it's unlikely that the full Model Version update can be finished in time. WDYT

@jerryshao
Copy link
Contributor

You can continue working on the other model version updating things, don't worry about the time.

@jerryshao
Copy link
Contributor

And for the doc, we can merge before the release based on the status at that time.

@Abyss-lord
Copy link
Collaborator Author

And for the doc, we can merge before the release based on the status at that time.

@jerryshao Thx, i will complete the Model Version update as soon as possible.

mchades and others added 4 commits April 22, 2025 11:18
…fileset credential (apache#6985)

### What changes were proposed in this pull request?

- using the HTTP header to specify the location name when getting
crednetial of the fileset
- gvfs automatically retrieves the corresponding credentials based on
the current location name.

### Why are the changes needed?

Fix: apache#6981 

### Does this PR introduce _any_ user-facing change?

no

### How was this patch tested?

local run `FilesetCatalogCredentialIT` and
`GravitinoVirtualFileSystemS3CredentialIT`
@Abyss-lord Abyss-lord requested a review from tengqm April 22, 2025 04:02
@Abyss-lord
Copy link
Collaborator Author

@jerryshao @tengqm , I've completed the code updates and would appreciate your review of the PR when you have a moment. Here's a summary of the commits:

  1. Add detailed documentation covering the ModelVersion changes.
  2. Update the OpenAPI specification to include the ModelVersion change endpoints.

@jerryshao
Copy link
Contributor

OK, I will review it today.

Comment on lines 635 to 636
by
sending a `PUT` request to the `/api/metalakes/{metalake_name}/catalogs/{catalog_name}/schemas/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you merge this two lines together, line 635 only has one word.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not changed from what I saw.

@Abyss-lord Abyss-lord requested a review from jerryshao April 22, 2025 07:15
@Abyss-lord
Copy link
Collaborator Author

Hi @jerryshao , I've completed the code updates and would appreciate your review of the PR when you have a moment. Here's a summary of the commits:

  1. Resolve all syntax errors.
  2. Standardize table formatting in the Markdown file.
  3. Remove the “Update Model” comment section.

@jerryshao jerryshao merged commit 509dab1 into apache:main Apr 22, 2025
27 checks passed
github-actions bot pushed a commit that referenced this pull request Apr 22, 2025
### What changes were proposed in this pull request?

Add doc to Model update. Except for Update Comment, this needs to wait
for PR merging.

### Why are the changes needed?

Fix: #6920

### Does this PR introduce _any_ user-facing change?

Add docs of Model update .

### How was this patch tested?

local test.

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: Qiming Teng <tengqm@outlook.com>
Co-authored-by: mchades <liminghuang@datastrato.com>
Co-authored-by: gavin.wang <gracejianbo@163.com>
Co-authored-by: FANNG <xiaojing@datastrato.com>
Co-authored-by: roryqi <he@datastrato.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Jerry Shao <jerryshao@datastrato.com>
Co-authored-by: yangyang zhong <35210666+hdygxsj@users.noreply.github.com>
Co-authored-by: Eric Chang <e850506@gmail.com>
Co-authored-by: Mini Yu <yuqi@datastrato.com>
Co-authored-by: Kang <zhoukangcn@gmail.com>
Co-authored-by: Justin Mclean <justin@classsoftware.com>
Co-authored-by: Danhua Wang <danhua@datastrato.com>
Co-authored-by: yunchi <yunchipang@gmail.com>
Co-authored-by: RickyMa <rickyma@tencent.com>
Co-authored-by: Yuhui <hui@datastrato.com>
@Abyss-lord Abyss-lord deleted the doc-model-update branch April 22, 2025 10:11
Abyss-lord added a commit to Abyss-lord/gravitino that referenced this pull request Apr 23, 2025
### What changes were proposed in this pull request?

Add doc to Model update. Except for Update Comment, this needs to wait
for PR merging.

### Why are the changes needed?

Fix: apache#6920

### Does this PR introduce _any_ user-facing change?

Add docs of Model update .

### How was this patch tested?

local test.

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: Qiming Teng <tengqm@outlook.com>
Co-authored-by: mchades <liminghuang@datastrato.com>
Co-authored-by: gavin.wang <gracejianbo@163.com>
Co-authored-by: FANNG <xiaojing@datastrato.com>
Co-authored-by: roryqi <he@datastrato.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Jerry Shao <jerryshao@datastrato.com>
Co-authored-by: yangyang zhong <35210666+hdygxsj@users.noreply.github.com>
Co-authored-by: Eric Chang <e850506@gmail.com>
Co-authored-by: Mini Yu <yuqi@datastrato.com>
Co-authored-by: Kang <zhoukangcn@gmail.com>
Co-authored-by: Justin Mclean <justin@classsoftware.com>
Co-authored-by: Danhua Wang <danhua@datastrato.com>
Co-authored-by: yunchi <yunchipang@gmail.com>
Co-authored-by: RickyMa <rickyma@tencent.com>
Co-authored-by: Yuhui <hui@datastrato.com>
Abyss-lord added a commit to Abyss-lord/gravitino that referenced this pull request Apr 27, 2025
### What changes were proposed in this pull request?

Add doc to Model update. Except for Update Comment, this needs to wait
for PR merging.

### Why are the changes needed?

Fix: apache#6920

### Does this PR introduce _any_ user-facing change?

Add docs of Model update .

### How was this patch tested?

local test.

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: Qiming Teng <tengqm@outlook.com>
Co-authored-by: mchades <liminghuang@datastrato.com>
Co-authored-by: gavin.wang <gracejianbo@163.com>
Co-authored-by: FANNG <xiaojing@datastrato.com>
Co-authored-by: roryqi <he@datastrato.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Jerry Shao <jerryshao@datastrato.com>
Co-authored-by: yangyang zhong <35210666+hdygxsj@users.noreply.github.com>
Co-authored-by: Eric Chang <e850506@gmail.com>
Co-authored-by: Mini Yu <yuqi@datastrato.com>
Co-authored-by: Kang <zhoukangcn@gmail.com>
Co-authored-by: Justin Mclean <justin@classsoftware.com>
Co-authored-by: Danhua Wang <danhua@datastrato.com>
Co-authored-by: yunchi <yunchipang@gmail.com>
Co-authored-by: RickyMa <rickyma@tencent.com>
Co-authored-by: Yuhui <hui@datastrato.com>
Abyss-lord added a commit to Abyss-lord/gravitino that referenced this pull request Apr 28, 2025
### What changes were proposed in this pull request?

Add doc to Model update. Except for Update Comment, this needs to wait
for PR merging.

### Why are the changes needed?

Fix: apache#6920

### Does this PR introduce _any_ user-facing change?

Add docs of Model update .

### How was this patch tested?

local test.

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: Qiming Teng <tengqm@outlook.com>
Co-authored-by: mchades <liminghuang@datastrato.com>
Co-authored-by: gavin.wang <gracejianbo@163.com>
Co-authored-by: FANNG <xiaojing@datastrato.com>
Co-authored-by: roryqi <he@datastrato.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Jerry Shao <jerryshao@datastrato.com>
Co-authored-by: yangyang zhong <35210666+hdygxsj@users.noreply.github.com>
Co-authored-by: Eric Chang <e850506@gmail.com>
Co-authored-by: Mini Yu <yuqi@datastrato.com>
Co-authored-by: Kang <zhoukangcn@gmail.com>
Co-authored-by: Justin Mclean <justin@classsoftware.com>
Co-authored-by: Danhua Wang <danhua@datastrato.com>
Co-authored-by: yunchi <yunchipang@gmail.com>
Co-authored-by: RickyMa <rickyma@tencent.com>
Co-authored-by: Yuhui <hui@datastrato.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch-0.9 Automatically cherry-pick commit to branch-0.9
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Improvement] Add doc to Model update