-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG][ALERT-SERVER]validate script before alert script #9834
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caishunfeng
reviewed
Apr 28, 2022
...alert-script/src/main/java/org/apache/dolphinscheduler/plugin/alert/script/ScriptSender.java
Outdated
Show resolved
Hide resolved
...alert-script/src/main/java/org/apache/dolphinscheduler/plugin/alert/script/ScriptSender.java
Outdated
Show resolved
Hide resolved
...alert-script/src/main/java/org/apache/dolphinscheduler/plugin/alert/script/ScriptSender.java
Show resolved
Hide resolved
caishunfeng
approved these changes
Apr 28, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
SonarCloud Quality Gate failed. |
Tianqi-Dotes
added a commit
to Tianqi-Dotes/dolphinscheduler
that referenced
this pull request
Jun 16, 2022
* validate script before alert script * fix validate script before alert script
brave-lee
pushed a commit
to brave-lee/dolphinscheduler
that referenced
this pull request
Jul 3, 2022
* validate script before alert script * fix validate script before alert script
lenboo
pushed a commit
that referenced
this pull request
Jul 3, 2022
* issue 8645 (#8811) Co-authored-by: 北笙 <“zhanqian@cai-inc.com”> Co-authored-by: zhanqian <zhanqian@cai-inc.com> * [fix-8929][DAO]Description Failed to upload the file because the full name was too long (#9020) * [fix-8929][DAO]Description Failed to upload the file because the full name was too long * [DS-#8929][fix]Description Failed to upload the file because the full name was too long * [DS-#8929][fix]Description Failed to upload the file because the full name was too long * [DS-#8929][fix]Description Failed to upload the file because the full name was too long Co-authored-by: houshuai <houshuai@jiguang.cn> * [BUG][ALERT-SERVER]validate script before alert script (#9834) * validate script before alert script * fix validate script before alert script * pick 8811/9020/9834 Co-authored-by: zhanqian <360400325@qq.com> Co-authored-by: 北笙 <“zhanqian@cai-inc.com”> Co-authored-by: zhanqian <zhanqian@cai-inc.com> Co-authored-by: shuai hou <120306274@qq.com> Co-authored-by: houshuai <houshuai@jiguang.cn> Co-authored-by: Tq <tianqitobethefirst@gmail.com> Co-authored-by: JinyLeeChina <jiny.li@foxmail.com>
brave-lee
added a commit
that referenced
this pull request
Jul 4, 2022
* issue 8645 (#8811) Co-authored-by: 北笙 <“zhanqian@cai-inc.com”> Co-authored-by: zhanqian <zhanqian@cai-inc.com> * [fix-8929][DAO]Description Failed to upload the file because the full name was too long (#9020) * [fix-8929][DAO]Description Failed to upload the file because the full name was too long * [DS-#8929][fix]Description Failed to upload the file because the full name was too long * [DS-#8929][fix]Description Failed to upload the file because the full name was too long * [DS-#8929][fix]Description Failed to upload the file because the full name was too long Co-authored-by: houshuai <houshuai@jiguang.cn> * [BUG][ALERT-SERVER]validate script before alert script (#9834) * validate script before alert script * fix validate script before alert script * pick 8811/9020/9834 * fix ut * fix pick error Co-authored-by: zhanqian <360400325@qq.com> Co-authored-by: 北笙 <“zhanqian@cai-inc.com”> Co-authored-by: zhanqian <zhanqian@cai-inc.com> Co-authored-by: shuai hou <120306274@qq.com> Co-authored-by: houshuai <houshuai@jiguang.cn> Co-authored-by: Tq <tianqitobethefirst@gmail.com> Co-authored-by: JinyLeeChina <jiny.li@foxmail.com>
zhongjiajie
pushed a commit
that referenced
this pull request
Jul 4, 2022
* issue 8645 (#8811) Co-authored-by: 北笙 <“zhanqian@cai-inc.com”> Co-authored-by: zhanqian <zhanqian@cai-inc.com> * [fix-8929][DAO]Description Failed to upload the file because the full name was too long (#9020) * [fix-8929][DAO]Description Failed to upload the file because the full name was too long * [DS-#8929][fix]Description Failed to upload the file because the full name was too long * [DS-#8929][fix]Description Failed to upload the file because the full name was too long * [DS-#8929][fix]Description Failed to upload the file because the full name was too long Co-authored-by: houshuai <houshuai@jiguang.cn> * [BUG][ALERT-SERVER]validate script before alert script (#9834) * validate script before alert script * fix validate script before alert script * pick 8811/9020/9834 * fix ut * fix pick error * fix 10762 Co-authored-by: zhanqian <360400325@qq.com> Co-authored-by: 北笙 <“zhanqian@cai-inc.com”> Co-authored-by: zhanqian <zhanqian@cai-inc.com> Co-authored-by: shuai hou <120306274@qq.com> Co-authored-by: houshuai <houshuai@jiguang.cn> Co-authored-by: Tq <tianqitobethefirst@gmail.com> Co-authored-by: JinyLeeChina <jiny.li@foxmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of the pull request
validate script before alert script
Brief change log
validate script before alert script
Verify this pull request
have tested locally.