Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update FunctionFactory::create to take the SessionState #9838

Closed
tshauck opened this issue Mar 28, 2024 · 0 comments · Fixed by #9837
Closed

Update FunctionFactory::create to take the SessionState #9838

tshauck opened this issue Mar 28, 2024 · 0 comments · Fixed by #9837
Labels
enhancement New feature or request

Comments

@tshauck
Copy link
Contributor

tshauck commented Mar 28, 2024

Is your feature request related to a problem or challenge?

Right now FunctionFactory::create takes the SessionConfig and not SessionState. This limits some of its utility in that access to the state is useful (e.g. loading an external file via the object store to set the function params).

Describe the solution you'd like

Update the trait so that implementations have access to SessionState.

Describe alternatives you've considered

No response

Additional context

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant