Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Benchmarks for group by spilling to disk #7571

Closed
alamb opened this issue Sep 15, 2023 · 0 comments · Fixed by #13090
Closed

Benchmarks for group by spilling to disk #7571

alamb opened this issue Sep 15, 2023 · 0 comments · Fixed by #13090
Labels
enhancement New feature or request

Comments

@alamb
Copy link
Contributor

alamb commented Sep 15, 2023

Is your feature request related to a problem or challenge?

@kazuyukitanimura added the group by spill feature in #7400 -- it would be great to

@sunchao #7400 (review) noted it would be nice to have benchmarks that cover the spilling code (current benchmarks only cover the case when there is no spilling and the grouping remains in memory):

Describe the solution you'd like

Suggestion from @sunchao #7400 (review):

It would be very nice if we can do some tests like in this PR: duckdb/duckdb#7931, which measures how performance may degrade as memory budget becomes lower.

Describe alternatives you've considered

No response

Additional context

No response

@alamb alamb added the enhancement New feature or request label Sep 15, 2023
@alamb alamb changed the title Benchmarks for spilling to disk Benchmarks for group by spilling to disk Sep 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant