Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible performance regressions #5061

Closed
andygrove opened this issue Jan 25, 2023 · 3 comments
Closed

Possible performance regressions #5061

andygrove opened this issue Jan 25, 2023 · 3 comments
Labels
bug Something isn't working

Comments

@andygrove
Copy link
Member

andygrove commented Jan 25, 2023

Describe the bug

I'm not 100% sure, but it looks like there may be performance regressions in DF 16. It could just be that some of these queries are quite variable in performance though.

This is average of 3 iterations of each query.

image

To Reproduce

Expected behavior

Additional context
https://sqlbenchmarks.io/sqlbench-h/results/env/workstation/sf10/single_node/

@andygrove andygrove added the bug Something isn't working label Jan 25, 2023
@ozankabak
Copy link
Contributor

ozankabak commented Jan 28, 2023

We are planning to dedicate some time into improving performance after we are done with the current features we are building (better optimizations, non-pipeline-breaking pruning symmetric hash join etc.). If this is a real regression and anyone can identify the cause, we can help fix/improve this in the upcoming weeks.

@mingmwang
Copy link
Contributor

Is it possible to add and compare the physical plan differences when we run the bench ?

@Dandandan
Copy link
Contributor

I think we can close it, this may have had to do with casting / type coercion changes which have been fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants