Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace TypeSignature::String with TypeSignature::Coercible #14759

Open
jayzhan211 opened this issue Feb 19, 2025 · 1 comment · May be fixed by #14917
Open

Replace TypeSignature::String with TypeSignature::Coercible #14759

jayzhan211 opened this issue Feb 19, 2025 · 1 comment · May be fixed by #14917
Assignees
@zjregee
Labels
enhancement New feature or request

Comments

@jayzhan211
Copy link
Contributor

jayzhan211 commented Feb 19, 2025 •
edited
Loading

Is your feature request related to a problem or challenge?

After #14440, we can use Coercible signature for existing String

                    TypeSignature::Coercible(vec![
                        Coercion::new_exact(TypeSignatureClass::Native(logical_string())),
                    ]),

Describe the solution you'd like

No response

And deprecate TypeSignature::String

Describe alternatives you've considered

No response

Additional context

#14440
#13301
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zjregee zjregee

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

replace TypeSignature::String with TypeSignature::Coercible zjregee/datafusion
2 participants
@jayzhan211 @zjregee