Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move ExpandWildcardRule into Logical Plan construction #14634

Open
rkrishn7 opened this issue Feb 12, 2025 · 4 comments
Open

Move ExpandWildcardRule into Logical Plan construction #14634

rkrishn7 opened this issue Feb 12, 2025 · 4 comments
Labels
enhancement New feature or request

Comments

@rkrishn7
Copy link
Contributor

Is your feature request related to a problem or challenge?

Related to #14618.

The first step in integrating analyzer rules in the builder stage is moving ExpandWildcardRule out of there and into the builder phase.

Describe the solution you'd like

No response

Describe alternatives you've considered

No response

Additional context

No response

@rkrishn7
Copy link
Contributor Author

Waiting until we decide on a path forward in #7765

@jayzhan211
Copy link
Contributor

I don't think removing Expr::Wildcard is that trivial given there is WildcardOptions and it doesn't block moving ExpandWildcardRule out of analyzer

@rkrishn7
Copy link
Contributor Author

@jayzhan211 Definitely, I don't think it's blocking either. I guess I was just thinking that if Expr::Wildcard gets removed, then it removes the need for this work. But sounds like you're saying it's pretty far away? And that integrating Analyzer within the LogicalPlan building stage is more immediately doable.

@jayzhan211
Copy link
Contributor

Even though Expr::Wildcard has been removed, we still need an equivalent concept and a way to "expand wildcard"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants