Skip to content

Commit 7fa0b8c

Browse files
authored
refactor!(SPM): rename Swift package from CordovaLib to Cordova (#1520)
This ends up being less confusing for everyone because the resulting framework is named Cordova.framework and the header paths are all <Cordova/*.h> but currently you need to reference the Swift dependency as "CordovaLib" rather than "Cordova". As far as I can tell from a quick search of public Package.swift files on GitHub, nobody has actually consumed this as a Swift package, so any breakage should be minimal and we should take the opportunity to do this right as part of the major version bump.
1 parent 82c1767 commit 7fa0b8c

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

Package.swift

+1-1
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ let package = Package(
2828
.macCatalyst(.v13)
2929
],
3030
products: [
31-
.library(name: "CordovaLib", targets: ["Cordova"])
31+
.library(name: "Cordova", targets: ["Cordova"])
3232
],
3333
dependencies: [],
3434
targets: [

templates/project/App.xcodeproj/project.pbxproj

+5-5
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@
2828
907F98562C06B87200D2D242 /* PrivacyInfo.xcprivacy in Resources */ = {isa = PBXBuildFile; fileRef = 907F98552C06B87200D2D242 /* PrivacyInfo.xcprivacy */; };
2929
907F98662C06BC1B00D2D242 /* config.xml in Resources */ = {isa = PBXBuildFile; fileRef = 907F98652C06BC1B00D2D242 /* config.xml */; };
3030
907F986A2C06BCD300D2D242 /* www in Resources */ = {isa = PBXBuildFile; fileRef = 907F98692C06BCD300D2D242 /* www */; };
31-
90A914592CA3D370003DB979 /* CordovaLib in Frameworks */ = {isa = PBXBuildFile; productRef = 90A914582CA3D370003DB979 /* CordovaLib */; };
31+
90A914592CA3D370003DB979 /* Cordova in Frameworks */ = {isa = PBXBuildFile; productRef = 90A914582CA3D370003DB979 /* Cordova */; };
3232
90BD9B7A2C06907D000DEBAB /* Base in Resources */ = {isa = PBXBuildFile; fileRef = 90BD9B792C06907D000DEBAB /* Base */; };
3333
90BD9B7C2C06907E000DEBAB /* Assets.xcassets in Resources */ = {isa = PBXBuildFile; fileRef = 90BD9B7B2C06907E000DEBAB /* Assets.xcassets */; };
3434
90BD9B7F2C06907E000DEBAB /* Base in Resources */ = {isa = PBXBuildFile; fileRef = 90BD9B7E2C06907E000DEBAB /* Base */; };
@@ -80,7 +80,7 @@
8080
isa = PBXFrameworksBuildPhase;
8181
buildActionMask = 2147483647;
8282
files = (
83-
90A914592CA3D370003DB979 /* CordovaLib in Frameworks */,
83+
90A914592CA3D370003DB979 /* Cordova in Frameworks */,
8484
);
8585
runOnlyForDeploymentPostprocessing = 0;
8686
};
@@ -190,7 +190,7 @@
190190
);
191191
name = App;
192192
packageProductDependencies = (
193-
90A914582CA3D370003DB979 /* CordovaLib */,
193+
90A914582CA3D370003DB979 /* Cordova */,
194194
);
195195
productName = App;
196196
productReference = 90BD9B6C2C06907D000DEBAB /* App.app */;
@@ -528,9 +528,9 @@
528528
/* End XCLocalSwiftPackageReference section */
529529

530530
/* Begin XCSwiftPackageProductDependency section */
531-
90A914582CA3D370003DB979 /* CordovaLib */ = {
531+
90A914582CA3D370003DB979 /* Cordova */ = {
532532
isa = XCSwiftPackageProductDependency;
533-
productName = CordovaLib;
533+
productName = Cordova;
534534
};
535535
/* End XCSwiftPackageProductDependency section */
536536
};

0 commit comments

Comments
 (0)