Fix type warnings and simplify code with auto boxing.

PlanetaryCode · dpogue · commit 755484b75ec8 · 2020-04-18T11:28:38.000-07:00
diff --git a/CordovaLib/Classes/Public/CDVPluginResult.m b/CordovaLib/Classes/Public/CDVPluginResult.m
@@ -103,7 +103,7 @@ - (CDVPluginResult*)initWithStatus:(CDVCommandStatus)statusOrdinal message:(id)t
 {
     self = [super init];
     if (self) {
-        status = [NSNumber numberWithInt:statusOrdinal];
+        status = @(statusOrdinal);
         message = theMessage;
         keepCallback = [NSNumber numberWithBool:NO];
     }
diff --git a/CordovaLib/Classes/Public/CDVViewController.m b/CordovaLib/Classes/Public/CDVViewController.m
@@ -472,7 +472,7 @@ - (UIInterfaceOrientationMask)supportedInterfaceOrientations
 
 - (BOOL)supportsOrientation:(UIInterfaceOrientation)orientation
 {
-    return [self.supportedOrientations containsObject:[NSNumber numberWithInt:orientation]];
+    return [self.supportedOrientations containsObject:@(orientation)];
 }
 
 - (UIView*)newCordovaViewWithFrame:(CGRect)bounds

Original file line number	Diff line number	Diff line change
`@@ -103,7 +103,7 @@ - (CDVPluginResult*)initWithStatus:(CDVCommandStatus)statusOrdinal message:(id)t`
`103`	`103`	`{`
`104`	`104`	`self = [super init];`
`105`	`105`	`if (self) {`
`106`		`- status = [NSNumber numberWithInt:statusOrdinal];`
	`106`	`+ status = @(statusOrdinal);`
`107`	`107`	`message = theMessage;`
`108`	`108`	`keepCallback = [NSNumber numberWithBool:NO];`
`109`	`109`	`}`
Original file line number	Diff line number	Diff line change
`@@ -472,7 +472,7 @@ - (UIInterfaceOrientationMask)supportedInterfaceOrientations`
`472`	`472`
`473`	`473`	`- (BOOL)supportsOrientation:(UIInterfaceOrientation)orientation`
`474`	`474`	`{`
`475`		`- return [self.supportedOrientations containsObject:[NSNumber numberWithInt:orientation]];`
	`475`	`+ return [self.supportedOrientations containsObject:@(orientation)];`
`476`	`476`	`}`
`477`	`477`
`478`	`478`	`- (UIView*)newCordovaViewWithFrame:(CGRect)bounds`