Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use chrono's quarter() to avoid conflict #7198

Merged
merged 1 commit into from
Feb 26, 2025

Conversation

yutannihilation
Copy link
Contributor

Which issue does this PR close?

Closes #7196.

Rationale for this change

chrono now provides .quarter() method, and arrow's .quarter() is not used elsewhere than this single file. So, this pull request replaces the .quarter() method.

The MSRV of chrono v0.4.40 is still 1.61, so it should be fine to update to this version.

What changes are included in this PR?

Are there any user-facing changes?

@github-actions github-actions bot added the arrow Changes to the arrow crate label Feb 26, 2025
@tustvold tustvold mentioned this pull request Feb 26, 2025
Copy link
Contributor

@tustvold tustvold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@@ -93,4 +93,4 @@ arrow-select = { version = "54.2.0", path = "./arrow-select" }
arrow-string = { version = "54.2.0", path = "./arrow-string" }
parquet = { version = "54.2.0", path = "./parquet", default-features = false }

chrono = { version = "0.4.34", default-features = false, features = ["clock"] }
chrono = { version = "0.4.40", default-features = false, features = ["clock"] }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@yutannihilation
Copy link
Contributor Author

Ah, I was actually about to close this pull request in favor of yours! lol

Thanks for reviewing!

@tustvold tustvold merged commit 2fddf85 into apache:main Feb 26, 2025
14 checks passed
@yutannihilation yutannihilation deleted the fix/chrono-quarter branch February 26, 2025 10:52
@haixuanTao
Copy link
Contributor

FYI, could be cool to release a new version quickly as this makes non version locked arrow not buildable.

@tustvold
Copy link
Contributor

tustvold commented Feb 26, 2025

The next release is currently scheduled for March - #7107

Unfortunately an Apache release has a lead time of at least 3 days, and I don't have the capacity to run the ceremony at this time, although if another maintainer is happy to do so that would be an option.

I would suggest either pinning chrono using a lockfile or an explicit dependency. It is unfortunate that chrono has released what is technically a breaking change in a patch release.

Edit: I have engaged the chrono developers to see if they might be able to assist/advise - chronotope/chrono#1666 (comment)

@Xuanwo
Copy link
Member

Xuanwo commented Feb 27, 2025

Unfortunately an Apache release has a lead time of at least 3 days, and I don't have the capacity to run the ceremony at this time, although if another maintainer is happy to do so that would be an option.

Hi, the ASF allows publishing hotfixes without a three-day voting period after a public discussion, as long as someone volunteers to be the RM. That means we can release a fix as long as we have gathered three +1 binding votes.

I'm happy to help with the release, but I'm not sure if it's possible for a non-committer to do so.

also cc @alamb

@alamb
Copy link
Contributor

alamb commented Feb 27, 2025

FYI we are tracking this in

@alamb
Copy link
Contributor

alamb commented Feb 27, 2025

we have released a hotfix to crates.io

The release is availale here: https://crates.io/crates/arrow/54.2.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ChronoDateExt::quarter() conflicts with chrono v0.4.40
5 participants