Substrait: Handle multiple select with the same table/columns in INTERSECT #6059
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cargo fmt cargo clippy --fix cleanup
alamb
approved these changes
Apr 22, 2023
There was a problem hiding this comment.
Looks a little hairy to me, but it makes sense that the join expressions need to be resolved in terms of the input schema (rather than the output schema, which is what build_join_schema makes).
cc @waynexia in case you have other thoughts
waynexia
approved these changes
Apr 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #6058.
Rationale for this change
Please refer to related issue.
What changes are included in this PR?
INTERSECTwith table/column reuseAre these changes tested?
Yes
Are there any user-facing changes?
No