Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build abi3 wheels for python binding #921

Closed
houqp opened this issue Aug 22, 2021 · 3 comments · Fixed by #927
Closed

Build abi3 wheels for python binding #921

houqp opened this issue Aug 22, 2021 · 3 comments · Fixed by #927
Labels
enhancement New feature or request

Comments

@houqp
Copy link
Member

houqp commented Aug 22, 2021

Is your feature request related to a problem or challenge? Please describe what you are trying to do.

For every python binding release, we are building python wheels for specific python patch versions.

Describe the solution you'd like

Build a single abi3 wheel for each platform for better forward compatibility and reduce complexity.

Here is an example of what abi3 wheel looks like: https://pypi.org/project/deltalake/#files.
It can be configured like so https://github.com/delta-io/delta-rs/blob/3f87e76d0462621993095760e537dcf21999c348/python/Cargo.toml#L27.

@houqp houqp added the enhancement New feature or request label Aug 22, 2021
@houqp
Copy link
Member Author

houqp commented Aug 22, 2021

@jorgecarleitao @jimexist @kszucs do you know if there is any particular reason why we are not building abi3 wheels? It's been working really well for deltalake's python binding, so I figured we might want to go with the same setup for datafusion as well.

@kszucs
Copy link
Member

kszucs commented Aug 24, 2021

In theory we should be able to build abi3 wheels. There are some limitations, but abi3 wheels look promising.

We may want to keep this issue open for later evaluation.

@houqp
Copy link
Member Author

houqp commented Aug 30, 2021

Good call @kszucs , I wasn't aware of that. I filed #955 to keep the task description more specific.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants