Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid package.json file in airflow/www #25007

Closed
2 tasks done
tm-drtina opened this issue Jul 12, 2022 · 1 comment · Fixed by #25065
Closed
2 tasks done

Invalid package.json file in airflow/www #25007

tm-drtina opened this issue Jul 12, 2022 · 1 comment · Fixed by #25065
Labels
area:UI Related to UI/UX. For Frontend Developers. kind:bug This is a clearly a bug

Comments

@tm-drtina
Copy link
Contributor

Apache Airflow version

2.3.3 (latest released)

What happened

According to npm docs fields name and version are required in package.json, but are not present in airflow/www/package.json
See: https://docs.npmjs.com/creating-a-package-json-file#required-name-and-version-fields

This can confuse some build tools, but also is just in incorrect format.

What you think should happen instead

The fields name and version should be defined even if they contain just dummy values - we don't need real values since the package is not published in npm registry.

How to reproduce

No response

Operating System

N/A

Versions of Apache Airflow Providers

No response

Deployment

Other

Deployment details

No response

Anything else

No response

Are you willing to submit PR?

  • Yes I am willing to submit a PR!

Code of Conduct

@tm-drtina tm-drtina added area:core kind:bug This is a clearly a bug labels Jul 12, 2022
@uranusjr uranusjr added area:UI Related to UI/UX. For Frontend Developers. and removed area:core labels Jul 13, 2022
@bbovenzi
Copy link
Contributor

@tm-drtina Good call. Feel free to open a PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:UI Related to UI/UX. For Frontend Developers. kind:bug This is a clearly a bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants