[all] Fix lint warnings

Signed-off-by: Oleksandr Grytsov <oleksandr_grytsov@epam.com>

Author: al1img

database/database_internal_test.go

@@ -401,7 +401,7 @@ func TestMultiThread(t *testing.T) {
 	go func() {
 		defer wg.Done()
 
-		for i := 0; i < numIterations; i++ {
+		for i := range numIterations {
 			if err := db.SetOperationVersion(uint64(i)); err != nil {
 				t.Errorf("Can't set operation version: %s", err)
 
@@ -424,7 +424,7 @@ func TestMultiThread(t *testing.T) {
 	go func() {
 		defer wg.Done()
 
-		for i := 0; i < numIterations; i++ {
+		for i := range numIterations {
 			if err := db.SetJournalCursor(strconv.Itoa(i)); err != nil {
 				t.Errorf("Can't set journal cursor: %s", err)
 
@@ -436,7 +436,7 @@ func TestMultiThread(t *testing.T) {
 	go func() {
 		defer wg.Done()
 
-		for i := 0; i < numIterations; i++ {
+		for range numIterations {
 			if _, err := db.GetJournalCursor(); err != nil {
 				t.Errorf("Can't get journal cursor: %s", err)
 
@@ -578,11 +578,12 @@ func TestInstances(t *testing.T) {
 	const (
 		testServiceID = "testService"
 		testSubjectID = "testSubject"
+		numInstances  = 5
 	)
 
-	var allInstances []launcher.InstanceInfo
+	allInstances := make([]launcher.InstanceInfo, 0, numInstances)
 
-	for i := 0; i < 5; i++ {
+	for i := range numInstances {
 		subjectInstance := launcher.InstanceInfo{
 			InstanceInfo: aostypes.InstanceInfo{
 				InstanceIdent: aostypes.InstanceIdent{

launcher/launcher_test.go

@@ -3024,8 +3024,8 @@ func compareArrays(len1, len2 int, isEqual func(index1, index2 int) bool) bool {
 	}
 
 loop1:
-	for i := 0; i < len1; i++ {
-		for j := 0; j < len2; j++ {
+	for i := range len1 {
+		for j := range len2 {
 			if isEqual(i, j) {
 				continue loop1
 			}
@@ -3036,8 +3036,8 @@ loop1:
 
 loop2:
 
-	for j := 0; j < len2; j++ {
-		for i := 0; i < len1; i++ {
+	for j := range len2 {
+		for i := range len1 {
 			if isEqual(i, j) {
 				continue loop2
 			}
@@ -3342,7 +3342,7 @@ func getSystemGroups(n int) (groups []string, err error) {
 		systemGroups = append(systemGroups, group)
 	}
 
-	for i := 0; i < n; i++ {
+	for i := range n {
 		groups = append(groups, systemGroups[i%len(systemGroups)])
 	}
 

logging/logging_test.go

@@ -164,7 +164,7 @@ func TestGetSystemLog(t *testing.T) {
 		till = from.Add(5 * time.Second)
 	)
 
-	for i := 0; i < 20; i++ {
+	for range 20 {
 		testJournal.addMessage("Hello World", "logger", "", "2")
 	}
 
@@ -307,7 +307,7 @@ func TestMaxPartCountLog(t *testing.T) {
 		till           = from.Add(20 * time.Second)
 	)
 
-	for i := 0; i < 200; i++ {
+	for i := range 200 {
 		testJournal.addMessage(fmt.Sprintf("Super mega log %d", i),
 			unitName, "/system.slice/system-aos@service.slice/"+unitName, "2")
 	}

networkmanager/networkmanager.go

@@ -588,7 +588,7 @@ func (manager *NetworkManager) createNetwork(
 
 func (manager *NetworkManager) generateVlanName() (string, error) {
 next:
-	for i := 0; i < countRetryVlanNameGeneration; i++ {
+	for range countRetryVlanNameGeneration {
 		vlanName, err := randomVlanName()
 		if err != nil {
 			return "", err

networkmanager/networkmanager_test.go

@@ -497,15 +497,15 @@ func TestUpdateNetwork(t *testing.T) {
 		t.Fatalf("Can't update networks: %v", err)
 	}
 
-	for i := 0; i < 2; i++ {
+	for range 2 {
 		select {
 		case <-vlanCreator.createVlanCh:
 		case <-time.After(time.Second):
 			t.Fatalf("Can't create vlan")
 		}
 	}
 
-	for i := 0; i < 2; i++ {
+	for range 2 {
 		select {
 		case <-storage.chanAddNetwork:
 		case <-time.After(time.Second):
@@ -934,7 +934,7 @@ func TestTrafficMonitoring(t *testing.T) {
 		t.Error("Unexpected system traffic")
 	}
 
-	for i := 0; i < 3; i++ {
+	for i := range 3 {
 		iptableInterface.waitUpdateIptablesCache()
 
 		in, out, err = manager.GetInstanceTraffic("instance1")
@@ -1440,7 +1440,7 @@ func (iptables *testIPTablesInterface) ListAllRulesWithCounters(table string) ([
 	var counters []string
 
 	for chain, iptablesData := range iptables.chain {
-		for i := 0; i < iptablesData.countChain; i++ {
+		for range iptablesData.countChain {
 			counters = append(counters, fmt.Sprintf("%s -c 0 %d", chain, iptablesData.limit))
 		}