[utils] Split grpchelpers.Start/Set, so conn. reset didnt wakeup invoke

Signed-off-by: Mykola Kobets <mykola_kobets@epam.com>

Author: mykola-kobets-epam

utils/grpchelpers/grpcconn.go

@@ -35,6 +35,7 @@ type GRPCConn struct {
 	sync.Mutex
 
 	grpcConn    *grpc.ClientConn
+	started     bool
 	connStarted sync.WaitGroup
 }
 
@@ -44,51 +45,59 @@ type GRPCConn struct {
 
 // NewGRPCConn creates new GRPCConn object.
 func NewGRPCConn() *GRPCConn {
-	conn := GRPCConn{}
+	conn := GRPCConn{started: false}
 
 	conn.connStarted.Add(1)
 
 	return &conn
 }
 
-// Start starts new grpc connection.
-func (conn *GRPCConn) Start(connection *grpc.ClientConn) error {
+// Set assigns new grpc connection.
+func (conn *GRPCConn) Set(connection *grpc.ClientConn) {
 	conn.Lock()
 	defer conn.Unlock()
 
-	if conn.grpcConn != nil {
-		return aoserrors.New("Previous connection should be stopped before reset")
-	}
-
 	conn.grpcConn = connection
-	conn.connStarted.Done()
+}
+
+// Start starts processing grpc calls.
+func (conn *GRPCConn) Start() {
+	conn.Lock()
+	defer conn.Unlock()
 
-	return nil
+	if !conn.started {
+		conn.started = true
+		conn.connStarted.Done()
+	}
 }
 
 // Stop stops current grpc connection.
 func (conn *GRPCConn) Stop() {
 	conn.Lock()
 	defer conn.Unlock()
 
-	if conn.grpcConn == nil {
-		return
+	if conn.grpcConn != nil {
+		conn.grpcConn.Close()
+		conn.grpcConn = nil
 	}
 
-	conn.grpcConn.Close()
-	conn.grpcConn = nil
-
-	conn.connStarted.Add(1)
+	if conn.started {
+		conn.started = false
+		conn.connStarted.Add(1)
+	}
 }
 
 // Close closes grpc connection and releases all spawned goroutines.
 func (conn *GRPCConn) Close() {
 	conn.Lock()
 	defer conn.Unlock()
 
-	if conn.grpcConn == nil {
+	if !conn.started {
+		conn.started = true
 		conn.connStarted.Done()
-	} else {
+	}
+
+	if conn.grpcConn == nil {
 		conn.grpcConn.Close()
 		conn.grpcConn = nil
 	}
@@ -102,7 +111,8 @@ func (conn *GRPCConn) Close() {
 func (conn *GRPCConn) Invoke(ctx context.Context, method string, args any, reply any,
 	opts ...grpc.CallOption,
 ) error {
-	lock := make(chan struct{}, 1)
+	lock := make(chan struct{})
+	defer close(lock)
 
 	go func() {
 		conn.connStarted.Wait()

utils/grpchelpers/grpcconn_test.go

@@ -46,9 +46,8 @@ func TestStoppedConnectionFails(t *testing.T) {
 
 	conn := grpchelpers.NewGRPCConn()
 
-	if err := conn.Start(grpcConn); err != nil {
-		t.Fatalf("Blocking connection start failed: err=%v", err)
-	}
+	conn.Set(grpcConn)
+	conn.Start()
 
 	if err := getNodeInfo(conn); err != nil {
 		t.Fatalf("Server started, GetNodeInfo call should succeed: err=%v", err)
@@ -76,9 +75,8 @@ func TestRPCBlockedUntilConnectionReset(t *testing.T) {
 
 	conn := grpchelpers.NewGRPCConn()
 
-	if err := conn.Start(grpcConn); err != nil {
-		t.Fatalf("Blocking connection start failed: err=%v", err)
-	}
+	conn.Set(grpcConn)
+	conn.Start()
 
 	if err := getNodeInfo(conn); err != nil {
 		t.Fatalf("GetNodeInfo call should succeed: err=%v", err)
@@ -111,9 +109,8 @@ func TestRPCBlockedUntilConnectionReset(t *testing.T) {
 		t.Fatalf("Connection failed: err=%v", err)
 	}
 
-	if err := conn.Start(grpcConn); err != nil {
-		t.Fatalf("Blocking connection start failed: err=%v", err)
-	}
+	conn.Set(grpcConn)
+	conn.Start()
 
 	if err := <-rpcResultChan; err != nil {
 		t.Fatalf("GetNodeInfo call should succeed: err=%v", err)