Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: use base64 instead of base58 for program show --buffers #5164

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat: use base64 instead of base58 for program show --buffers #5164

wants to merge 1 commit into from
+10 −3

Conversation

sonicfromnewyoke
Copy link

Problem

The fetching of program accounts is too slow due to the usage of base58 encoding filters.
closes #5157

Summary of Changes

  • added new_base64_encoded fn for Memcmp which encodes filter with base64
  • used new_base64_encoded instead of new_base58_encoded in CLI during the execution of solana program show --buffers command

@mergify mergify bot requested a review from a team March 6, 2025 04:40
@mergify Mergify
Copy link

mergify bot commented Mar 6, 2025

If this PR represents a change to the public RPC API:

  1. Make sure it includes a complementary update to rpc-client/ (example)
  2. Open a follow-up PR to update the JavaScript client @solana/web3.js (example)

Thank you for keeping the RPC clients in sync with the server API @sonicfromnewyoke.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
community need:merge-assist
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update solana program show --buffers to use base64 encoding
1 participant
@sonicfromnewyoke