couple notes to self

2501babe · 2501babe · commit 187f4ef7c910 · 2025-04-01T12:44:22.000-07:00
diff --git a/svm/src/transaction_balances.rs b/svm/src/transaction_balances.rs
@@ -145,6 +145,9 @@ impl BalanceCollector {
     }
 }
 
+// HANA we probably want to capture the balance timings in txp
+// make sure to delete any writes to those timings that might exist in runtime/ledger/core
+// in any event our version should be much faster than the existing one since we use AccountLoader
 impl BalanceCollectionRoutines for BalanceCollector {
     fn collect_pre_balances<CB: TransactionProcessingCallback>(
         &mut self,
@@ -253,6 +256,7 @@ impl BalanceCollectionRoutines for Option<BalanceCollector> {
     }
 }
 
+// HANA if we add mints to inline-spl we could parse the mint here instead of holding it
 pub struct SvmTokenInfo {
     pub account_index: u8,
     pub mint: Pubkey,

Original file line number	Diff line number	Diff line change
`@@ -145,6 +145,9 @@ impl BalanceCollector {`
`145`	`145`	`}`
`146`	`146`	`}`
`147`	`147`
	`148`	`+// HANA we probably want to capture the balance timings in txp`
	`149`	`+// make sure to delete any writes to those timings that might exist in runtime/ledger/core`
	`150`	`+// in any event our version should be much faster than the existing one since we use AccountLoader`
`148`	`151`	`impl BalanceCollectionRoutines for BalanceCollector {`
`149`	`152`	`fn collect_pre_balances<CB: TransactionProcessingCallback>(`
`150`	`153`	`&mut self,`
`@@ -253,6 +256,7 @@ impl BalanceCollectionRoutines for Option<BalanceCollector> {`
`253`	`256`	`}`
`254`	`257`	`}`
`255`	`258`
	`259`	`+// HANA if we add mints to inline-spl we could parse the mint here instead of holding it`
`256`	`260`	`pub struct SvmTokenInfo {`
`257`	`261`	`pub account_index: u8,`
`258`	`262`	`pub mint: Pubkey,`