This repository has been archived by the owner on Jan 8, 2023. It is now read-only.
development #14
Merged
development #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ssbarnea
approved these changes
Jun 2, 2021
There was a problem hiding this comment.
Removal of ansible-lint from pre-commit makes sense because we do not have any in-repo ansible code.
Still, ideally we should lint the generated code when creating a new scenario using current driver, so we assure that our cookiecutter templates pass linting. This need to be done as part of the tests and not on pre-commit. If you can do it it would be nice.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
createanddestroyplaybooks