Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Phase out use of VotingPower struct #455

Closed
Tracked by #340
brentstone opened this issue Sep 8, 2022 · 0 comments · Fixed by #707
Closed
Tracked by #340

Phase out use of VotingPower struct #455

brentstone opened this issue Sep 8, 2022 · 0 comments · Fixed by #707
Assignees

Comments

@brentstone
Copy link
Collaborator

The VotingPower struct is just a wrapper around a u64, and with the decision to adopt votes_per_token = 1 per namnam, there isn't much use for passing around VotingPower in the code. If anything, this may still be used only in direct communication with tendermint, but otherwise should be replaced with an Amount or just a u64 itself. This will result in cleaner and more succinct code.

@brentstone brentstone self-assigned this Sep 8, 2022
@tzemanovic tzemanovic moved this to Todo in Namada-Old Sep 9, 2022
@tzemanovic tzemanovic moved this from Todo to WIP in Namada-Old Sep 9, 2022
This was referenced Oct 25, 2022
Repository owner moved this from WIP to Tested in Devnet in Namada-Old Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Tested in Devnet
Development

Successfully merging a pull request may close this issue.

2 participants