Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove disposable-gas-payer from TxCustom #3963

Closed
grarco opened this issue Oct 31, 2024 · 0 comments · Fixed by #3969
Closed

Remove disposable-gas-payer from TxCustom #3963

grarco opened this issue Oct 31, 2024 · 0 comments · Fixed by #3969
Labels
breaking:cli command line breaking change cli client

Comments

@grarco
Copy link
Collaborator

grarco commented Oct 31, 2024

In the cli we allow passing in a --disposable-gas-payer when loading a tx from storage for the tx command. It doesn't really make sense though to allow for it: if the previously dumped tx (or the first tx of the batch) is indeed doing masp fee payment, then it must be already pointing to a disposable address (generated when the transaction was constructed) that won't match the one we'll generate here and should instead be passed manually. If the tx we are loading does not involve gas payment via the shielded pool instead, generating a disposable address would lead to a failure when submitting it since fees cannot be paid.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking:cli command line breaking change cli client
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant