Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only re-export current CometBFT version in use #3248

Closed
sug0 opened this issue May 15, 2024 · 0 comments · Fixed by #3697
Closed

Only re-export current CometBFT version in use #3248

sug0 opened this issue May 15, 2024 · 0 comments · Fixed by #3697
Labels
bug Something isn't working prio:low
Milestone
Nice to have and ...

Comments

@sug0
Copy link
Collaborator

sug0 commented May 15, 2024

In namada_core, we should only re-export v0.37.x related tendermint-rs modules, to avoid accidentally using v0.34.x or v0.38.x data structures, which might be incompatible.
@sug0 sug0 added bug Something isn't working prio:low labels May 15, 2024
@sug0 sug0 added this to the Later / optional milestone May 15, 2024
@tzemanovic tzemanovic mentioned this issue Aug 23, 2024
Merged
1 task
@mergify mergify bot closed this as completed in #3697 Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working prio:low
Projects
None yet
Milestone
Nice to have and non-breaking
Development

Successfully merging a pull request may close this issue.

refactor tendermint-rs reexports anoma/namada
2 participants
@sug0 @cwgoes