Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does it make sense to be able to pass threshold=0 on init-account ? #2671

Closed
phy-chain opened this issue Feb 20, 2024 · 3 comments · Fixed by #3154
Closed

Does it make sense to be able to pass threshold=0 on init-account ? #2671

phy-chain opened this issue Feb 20, 2024 · 3 comments · Fixed by #3154
Labels
bug Something isn't working

Comments

@phy-chain
Copy link

namada client init-account      \
    --threshold 0   \
    --alias test-account-to-update2   \
    --signing-keys validatorade     \
    --memo tpknam1qpayc0rxtuulknrvygcwvlhehuw2tvmxhvhxmjm8s43hxj3vdxjlv62jzcq

This works without any warning. What would be the consequences of having a 0 threshold account ? Possibility of not signing tx ?

@sug0
Copy link
Collaborator

sug0 commented Feb 22, 2024

hm, this shouldn't make sense. the consequences seem to be that no signatures are required to validate an action within that account

@sug0 sug0 added the bug Something isn't working label Feb 22, 2024
@phy-chain
Copy link
Author

Yep, I confirm. Tested this morning, and you can also lower it to 0 through update-account :
namadac update-account --address test-establied-0 --threshold 0 --signing-keys $KEY_ALIAS --memo $NAMADA_MEMO --node http://rpc.namada.validatorade.org

Indeed, no signing required afterward, I can transfer funds with this account without signing

@phy-chain
Copy link
Author

I have also fixed "init-validator" to enforce a threshold > 0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants