Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wasm secp256k1 sig verification is missing #1595

Closed
tzemanovic opened this issue Jun 20, 2023 · 0 comments · Fixed by #1599
Closed

wasm secp256k1 sig verification is missing #1595

tzemanovic opened this issue Jun 20, 2023 · 0 comments · Fixed by #1599
Assignees
Labels
bug Something isn't working wasm

Comments

@tzemanovic
Copy link
Member

Trying to use secp256k1 signatures fails verification in WASM VPs with a runtime error. This is because the fn verify_signature has conditional compilation for feature = "secp256k1-sign-verify", which controls whether the hmac feature is enabled for libsecp256k1 (https://github.com/paritytech/libsecp256k1). However, hmac is only needed for creating signatures not for verifying them, so we can enable these. We should make sure to have a test case for tx signed with a secp256k1 key

@tzemanovic tzemanovic added the bug Something isn't working label Jun 20, 2023
@tzemanovic tzemanovic self-assigned this Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working wasm
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant