Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Wrong NMEA format when phone locale is not US #9

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix: Wrong NMEA format when phone locale is not US #9

wants to merge 2 commits into from

Conversation

filipkemuel
Copy link

  • Fixed Wrong NMEA format when phone locale is not US #7 - Strings are now formatted with US locale.
  • Changed service name to make it more descriptive instead of ID number
  • Set hostname of JmDNS service to phone-name instead of ip-address
  • Switched to api 26
  • Replaced most deprecated functions
  • Changed scope of functions to minimize resource use
  • Fixed different errors that the debugger found
  • Added Danish localization

@filipkemuel
* Fixed ankitstarski#7 - Strings are now formatted with US locale.
af8dda5 
* Changed service name to make it more descriptive instead of ID number
* Set hostname of JmDNS service to phone-name instead of ip-address
* Switched to api 26
* Replaced most deprecated functions
* Changed scope of functions to minimize resource use
* Fixed different errors that the debugger found
@filipkemuel
Added Danish localization
fcd2320
@filipkemuel filipkemuel changed the title Fix for #7 Fix: Wrong NMEA format when phone locale is not US May 14, 2019
@bigon
Copy link

bigon commented Oct 23, 2020

Can we hope this to be merged one day (and even better a new release of the application?)

@promeneur
Copy link

It's a pity almost 2 years and not any new release with the fix.

Anyway, thanks for the fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wrong NMEA format when phone locale is not US
3 participants
@filipkemuel @bigon @promeneur