-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dialog so complicated #1180
Comments
I personally like this API the best ng-bootstrap/ng-bootstrap#3 (comment) (and following discussion) and it shouldn't even be that hard to make, since I've finally figured out how to use that portal / overlay combo #998 (comment) |
We feel that a declarative API really doesn't make sense for components like dialog, snackbar, etc. @Zigzag95 Saying the implementation is "too complicated" is not a bug, feature request, or proposal for Material. It's as complicated as it has to be to support AoT compilation. |
@jelbourn I'd argue that for modal particularly it does a) it's how the native |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
First of all, chapeau bas @jelbourn for writing down this amazing dialog code.
But I don't understand why it's so complicated adding components dynamically with ng2
I think a piece of api like hereafter is missing:
let factory = getFactory(myCmp);
let cmp = factory.createInstance();
this.renderer.addChildComponent(this.htmlElement);
The text was updated successfully, but these errors were encountered: